Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1398070imm; Fri, 8 Jun 2018 15:41:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK0ndOR3A9DiZQsWGVeMZuOQa4KdF2qv6mx1WA8TKgvJCQgnfusLpUfiXjV2n6eWeSMbIbC X-Received: by 2002:a17:902:c3:: with SMTP id a61-v6mr8418712pla.149.1528497681143; Fri, 08 Jun 2018 15:41:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528497681; cv=none; d=google.com; s=arc-20160816; b=PwhoVEajq9Xbv81kzcdn+EGuCIMgPsXFhL9kWiYfvosK9zIchkaD9vkk78qXnJdOXu hvNf9iWg2Au5m/ym4j6ffsx+lcJ+eyCcqOgxGrxer3juEVBCkbcXBp69ll/rgarzKPmI VIwsxbSANHlSWdGiR/73UT4sNWsKVe+i4E0CVL3bcK5/+CWaPjwEXEUzYhKlPL5G5nGz 62Rc/YbI0OcA8k5Xlm78Td6Cy/3yIoF86ERDlmqMh06aLDqkkrXAAL0QiLD83WhMO/Qw 8FdSuAvOCJnI840B2Gak+MhkAGLkwOWIkDvkAM9rrvYZKHOAzTUzAX+kFiy23ul+vgy2 q73A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=L/slwB6XILDeVDrm19uY08zNJ18tT3lMio6tqqX36g8=; b=F3Ksb79BlfSwA72AKoGStkF+xvxJVanvu5fOMln562cLuZErqhvloxW/Vx2IpL1pL3 c/002frECAHZy4S03q//CT+0dMQvD8wejIPey0izPruCgWMthU0X+/bBH+jTy5izXqIy KBVqfiSaavTYjX80HlAiWY7zC9Su0n6DouIeAzzq1L4cXl19JVe5ke4xTjfPWSt5wweq wc091Ta5hYyYYlDgt4daF/IkPa022U7JNn/f55JF7TVZFjtODAYUaP7CwIJsiei8UXIY CbB6Cv/3C3msH44E9ahL3psiIJoK6m/xKGY8nftfNdf0Pbcds/X71libUSfD1W9RNBk6 HFmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u1-v6si16896448pgo.114.2018.06.08.15.41.06; Fri, 08 Jun 2018 15:41:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753037AbeFHWko (ORCPT + 99 others); Fri, 8 Jun 2018 18:40:44 -0400 Received: from mga12.intel.com ([192.55.52.136]:33179 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbeFHWkn (ORCPT ); Fri, 8 Jun 2018 18:40:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2018 15:40:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,491,1520924400"; d="scan'208";a="235647956" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by fmsmga005.fm.intel.com with ESMTP; 08 Jun 2018 15:40:42 -0700 Date: Fri, 8 Jun 2018 16:43:30 -0600 From: Keith Busch To: "poza@codeaurora.org" Cc: Bjorn Helgaas , Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dongdong Liu , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH NEXT 6/6] PCI/PORTDRV: Remove ERR_FATAL handling from pcie_portdrv_slot_reset() Message-ID: <20180608224330.GA25132@localhost.localdomain> References: <1528351234-26914-1-git-send-email-poza@codeaurora.org> <1528351234-26914-6-git-send-email-poza@codeaurora.org> <94661add3e71e3694aa22c2a9cabf503@codeaurora.org> <20180607213448.GB37077@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 07, 2018 at 09:47:42PM -0700, poza@codeaurora.org wrote: > Keith, > > do you know why in ERR_FATAL case following was done ? > have a look at pcie_portdrv_slot_reset() handling (for bridges, switches > etc..) Not sure, but I was looking into some issues in this area anyway. I'm finding that non-hotpluggable bridges that support D3 are getting put into that low-power mode, and that pretty much breaks the re-enumeration.