Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <6471e14e-2872-3ba4-7336-7c5840d28c12@gmail.com>
References: <15599.1528402643@turing-police.cc.vt.edu> <fe2d6bfd-17a3-8464-175d-3e8714e14827@gmail.com>
 <10902.1528416198@turing-police.cc.vt.edu> <6471e14e-2872-3ba4-7336-7c5840d28c12@gmail.com>
From:   Dexuan-Linux Cui <dexuan.linux@gmail.com>
Date:   Fri, 8 Jun 2018 19:54:30 -0700
Message-ID: <CAA42JLYGOR1hJnOvdvSbyK6z7wb0jG8TtXsXoNZU9xnK1cKjVA@mail.gmail.com>
Subject: Re: next-20180605 - BUG in ipv6_add_addr
To:     David Ahern <dsahern@gmail.com>
Cc:     valdis.kletnieks@vt.edu, netdev@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Dexuan Cui <decui@microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 7, 2018 at 5:51 PM, David Ahern <dsahern@gmail.com> wrote:
>
> ...
> I know you don't have a reliable reproducer, but I did find one spot
> where I was too clever and did not initialize a new cfg variable:
>
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 89019bf59f46..59c22a25e654 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -1324,6 +1324,7 @@ static int ipv6_create_tempaddr(struct
> inet6_ifaddr *ifp,
>                 }
>         }
>
> +       memset(&cfg, 0, sizeof(cfg));
>         cfg.valid_lft = min_t(__u32, ifp->valid_lft,
>                               idev->cnf.temp_valid_lft + age);
>         cfg.preferred_lft = cnf_temp_preferred_lft + age -
> idev->desync_factor;

This works for me. Great!

Thanks,
-- Dexuan