Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1680738imm; Fri, 8 Jun 2018 22:56:18 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIVH/1kE1hs1Ojo/oMgkFZm3j2GLBCDfZhg1eIaMkDYaKgHH8hNNzwQrSKE/wFkR7AeE5EK X-Received: by 2002:a17:902:9b82:: with SMTP id y2-v6mr2831784plp.69.1528523778606; Fri, 08 Jun 2018 22:56:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528523778; cv=none; d=google.com; s=arc-20160816; b=bWu/y6qXmX7ktkXGuNdkahF44Q8Ai3I21dZvbs4TDfXi1WCTmyZNLiUOqvA7k2FyfR LyIvNkP2q+8DDkED6xCHH/kpEqQO+2kaZ4Kx3pBEK0OSG25fe2VKvyBCu9oE9w9B4Nrl heE0vnoI/iojnJjOtJhnxe9tBGnkyScxzSloXSPuwz8F6IgK43FmnPg/juX7a5Floa7k CL9WTC6hSsYPlAnhFBsjTfapbASBEqgqVd/Jq6Fw1PStsvd6hCRfW8Gcbzlv+6088ni1 Jxh745AnTvoXoJkonuWPQV+Rb0Zy6iX8cHrZq1d1zTCEIcc4O5M9xG0/2XJDGy0e+iYi /x1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=aeXr1d0Ek9vq0Urhew2WTnHfYxmKG9BW6ygcAE4xZb4=; b=joaP42YBGFpmdZBnVHRR1bXKB9Du8aQ+FBgOcFOjGUbUet73SAV56NZQs2Q+JZVUMr w9uDB29Df7fpUgduq95fct+mwocKEIuWLmW8Uy0kl6Zuzn4/5ynIA+TEsEwyZBktdXnZ bJKujrjOogSomoumBCeRNvyPuK8KzuuYJBqdW0vancswWeDNzQbfO9A1Hx4DgJPzx97O TGCKaz/oT/CUhzeKF3B4p0TEbt2xLIyPBdhQ94HEnUx25poVIbF0BOexkk0sdC4zxYNp jAAmqJJLk43wEYLKpiRb6TN6z30EBZQ338C2tUXPsVNCGYu0eru9wBlM8k8qeHyfuKyu 2zNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4-v6si23830055pgd.518.2018.06.08.22.56.04; Fri, 08 Jun 2018 22:56:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756AbeFIFzd (ORCPT + 99 others); Sat, 9 Jun 2018 01:55:33 -0400 Received: from mail.bootlin.com ([62.4.15.54]:50232 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751363AbeFIFzc (ORCPT ); Sat, 9 Jun 2018 01:55:32 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id 3FC0E207CA; Sat, 9 Jun 2018 07:55:30 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id A6FEE203EC; Sat, 9 Jun 2018 07:55:29 +0200 (CEST) Date: Sat, 9 Jun 2018 07:55:29 +0200 From: Boris Brezillon To: Stefan Agner Cc: dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, thierry.reding@gmail.com, dev@lynxeye.de, miquel.raynal@bootlin.com, richard@nod.at, marcel@ziswiler.com, krzk@kernel.org, digetx@gmail.com, benjamin.lindqvist@endian.se, jonathanh@nvidia.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, mirza.krak@gmail.com, linux-mtd@lists.infradead.org, linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/6] mtd: rawnand: add NVIDIA Tegra NAND Flash controller driver Message-ID: <20180609075529.23be0658@bbrezillon> In-Reply-To: <20180531221637.6017-5-stefan@agner.ch> References: <20180531221637.6017-1-stefan@agner.ch> <20180531221637.6017-5-stefan@agner.ch> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 1 Jun 2018 00:16:35 +0200 Stefan Agner wrote: > + > +static const struct of_device_id tegra_nand_of_match[] = { > + { .compatible = "nvidia,tegra20-nand" }, > + { /* sentinel */ } > +}; > + > +static struct platform_driver tegra_nand_driver = { > + .driver = { > + .name = "tegra-nand", > + .of_match_table = tegra_nand_of_match, > + }, > + .probe = tegra_nand_probe, > + .remove = tegra_nand_remove, > +}; > +module_platform_driver(tegra_nand_driver); > + > +MODULE_DESCRIPTION("NVIDIA Tegra NAND driver"); > +MODULE_AUTHOR("Thierry Reding "); > +MODULE_AUTHOR("Lucas Stach "); > +MODULE_AUTHOR("Stefan Agner "); > +MODULE_LICENSE("GPL v2"); > +MODULE_DEVICE_TABLE(of, tegra_nand_of_match); Just a nitpick: can you move this MODULE_DEVICE_TABLE() just after the tegra_nand_of_match declaration?