Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1723926imm; Fri, 8 Jun 2018 23:58:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL8Ex4LEJIZsdGMZZy1UATEG8plYa8n4iYfuMUgPZbi34gkPN8VfNeZxWH52eiUx5IrFg2a X-Received: by 2002:a63:bf49:: with SMTP id i9-v6mr7907443pgo.342.1528527536011; Fri, 08 Jun 2018 23:58:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528527535; cv=none; d=google.com; s=arc-20160816; b=irWo6GKi6ppQ5sqxCPGxf3GJjF/ydQGbjcYSNvYSACO1zN2npeOO9zKsh/0ftk3s6Q u2eBoHX2aS/A98ZXIvKd87yKu3R5EbCeo40K83SqRhnLGjF+ZgRYglfO7ARMqTe6tAFB Spz5eSdrccNdb7RIpy0ydc3wJvbxF20ccbKK3iVg3nspISkRtP5dU01vj8H/rTuB2utw PNStxux7OXqOe+dnHc9tbylm1HdNk5xegoZJMKn1o7Cg/KNACyIXArHn67UTTF54BfiU 3PRbflErXYzV4Dj6gZLRdLWE3P262in1OVWRmmz8v6hfgLZHwwCtO7rjiGqOAgr0FKRW +f5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=uZBqoWtjjeUzY2076A/z+mJX2jdlBeb1CpwbvAQbF8Y=; b=bSeEuw6b16076eNjxEEAjRi9l6kH+DjaHUEP6bu/2eoWw0ZeUKua98LfltpC6jULKi U9sj7RVv0R2eFHaLtMWKzNVMSZsGH6RqxtdUhc71dIodq6JHE/JBvD7fFWbnMUNLb7po NGxEpNpgz4xuznfsfV80kmrI1d4iBCXxqdzMpJXSID8/cmM+yTx2yntoh3e0jAI8an+Z NhNn0z4kQ9mZ+CFoMEqjBSmGIDzu8nig1GR2Ay+GCJhyywVZDQ8iO4qmyWIU9KCVGUg/ 0DJ8++NpgpDBYbqQEc3vECIZ7aGa4O2NWpUKGTo3OnHYXjXHqj5QkUgJHN96NsyFOyia L6rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@konsulko.com header.s=google header.b=NfcsRwzf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u5-v6si2439842pfn.339.2018.06.08.23.58.41; Fri, 08 Jun 2018 23:58:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@konsulko.com header.s=google header.b=NfcsRwzf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbeFIG6Q (ORCPT + 99 others); Sat, 9 Jun 2018 02:58:16 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:46939 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752599AbeFIG6P (ORCPT ); Sat, 9 Jun 2018 02:58:15 -0400 Received: by mail-pl0-f66.google.com with SMTP id 30-v6so9463670pld.13 for ; Fri, 08 Jun 2018 23:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=from:to:cc:subject:date:message-id; bh=uZBqoWtjjeUzY2076A/z+mJX2jdlBeb1CpwbvAQbF8Y=; b=NfcsRwzfOyY1M+2K10Ycdy7AWniusH97gOrTbHgtaoRAZ3cNx0IaA2bJSoiV7FNVY6 HBKxdkD8QAoP1QSi7zoBL97gc8lqzpoCwq6MXfklp7gXyWR/g3jXWkXwPbS4drkOrUay UWFz5my7w+pqZSxrJdYaCjxl78zzW4O6CHAsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=uZBqoWtjjeUzY2076A/z+mJX2jdlBeb1CpwbvAQbF8Y=; b=PMLxDrEcAfJ4hjbLBCTHYRjFifhJB/v30lJaEPZWTtYzlnA7JVZHjlWl2gZRSEObAr lQnli/ah8FhXsc3aOD574rbZR/5hKTKQ37th9FSdDTniJ5cHb4b7EI7OVYfulUPZApJZ /7sk1sT96PMbRA0wIdpmi2BWsFD5rXOMJTYRi/FiU4Fa/2DNR6R1JjmNPALj/8mmj4Y+ 8+h5j8kWq1zWdQ/xKaMvyuI1p/LaKBeLzVUCR5pY4wO7t5a69ond6jNCj34CkncCAMux T5LY9n/xntZkZl8W8N9U2BTNVhv7xZAg2CCAzX2byO3FnwhKvWot8kjo/Gh9gGehyCpz Pz9A== X-Gm-Message-State: APt69E1t/umVT4H7pTZlYZbWykPDihedE3uHgY/WWSpQjJAghfncmJuI rtDBv211H6N1aSrG4d+V4vdXDDsQqy4= X-Received: by 2002:a17:902:b786:: with SMTP id e6-v6mr9791709pls.260.1528527495223; Fri, 08 Jun 2018 23:58:15 -0700 (PDT) Received: from niteshade.hsd1.or.comcast.net ([2601:1c2:5000:8d45::3f0e]) by smtp.gmail.com with ESMTPSA id 9-v6sm40269427pfn.129.2018.06.08.23.58.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Jun 2018 23:58:14 -0700 (PDT) From: Matt Ranostay To: linux-kernel@vger.kernel.org Cc: Matt Ranostay , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH] tsl2550: fix lux1_input error in low light Date: Fri, 8 Jun 2018 23:58:15 -0700 Message-Id: <20180609065815.6005-1-matt.ranostay@konsulko.com> X-Mailer: git-send-email 2.14.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ADC channel 0 photodiode detects both infrared + visible light, but ADC channel 1 just detects infrared. However, the latter is a bit more sensitive in that range so complete darkness or low light causes a error condition in which the chan0 - chan1 is negative that results in a -EAGAIN. This patch changes the resulting lux1_input sysfs attribute message from "Resource temporarily unavailable" to a user-grokable lux value of 0. Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Signed-off-by: Matt Ranostay --- drivers/misc/tsl2550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/tsl2550.c b/drivers/misc/tsl2550.c index adf46072cb37..3fce3b6a3624 100644 --- a/drivers/misc/tsl2550.c +++ b/drivers/misc/tsl2550.c @@ -177,7 +177,7 @@ static int tsl2550_calculate_lux(u8 ch0, u8 ch1) } else lux = 0; else - return -EAGAIN; + return 0; /* LUX range check */ return lux > TSL2550_MAX_LUX ? TSL2550_MAX_LUX : lux; -- 2.14.1