Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1793823imm; Sat, 9 Jun 2018 01:36:02 -0700 (PDT) X-Google-Smtp-Source: ADUXVKK1t5DH0LLxljW91fEcszfqxRRA9Sv33KHj+lxFS418CYk7UmK6O9gyPXhMpBFsn3SdwUtO X-Received: by 2002:a63:ac11:: with SMTP id v17-v6mr8149405pge.274.1528533362408; Sat, 09 Jun 2018 01:36:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528533362; cv=none; d=google.com; s=arc-20160816; b=IiotID6dxVBUfKgQQqeA/6Owk0Gbona+N3f2i6EOIY38Uu/DXj8ayjUDtvFErHmt68 ZrGltCf0AxphJaXoI/O+nMOjpgKj7PBkwK0U5oIuMYbZO+gQLZs7dc58rdYxWsFs7XDU V9/nw+voSgucBO3Vs87ycF3UpL97INt2vIWQnR8kyedhDc7EC5Bs3GsnVB1ogFVZFxRV PZvXC+TNpySUNcj4JhlXDaZDCkc6PwkWAuGBW+C8FrDLD32PSJBrg8ksxgjbcu8g5xmE m7Q36sYBnLkpr0nnR5U0SPQ9R1e+j0Yu6Un5hZZ+/nD7tudj/1JVp1txa4xfuxg6eCoz lpBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:cc:to:from :date:arc-authentication-results; bh=rcBAz/suJOlvsyR1/zrusah86FC4oxPpNroZgskxT0E=; b=I7q+NVMprHJQLRcAeaeu3RHJWjFl7pnNuURL60xtwO/3ooMleHfdf7s0Dc8wHgDtEL zXikAi5DUkg7/LdQkeVBA/hWljxZUmAC8UUn+v8YUCUmyvN+PQaM0qH2IJ6tLJDKOOW1 rHCZNJlvBcltTVArjHx7dwpCXpQw0zyfTeQhFeBHWql5VOOlvixaS52dWTRZqQoId+dO fM9ExUr/f5MTEQr6IXHWwtAGdRDcckL1Mc8scnLXe7QS8EjpRTqUvaiJ5Dr+MsNE06e8 DxxVlHoRUF1O/KCHgOkUkFSNQy8cwqcCC6/5qH3RPUUY1zUBXlXMKa0KYm2OofeH73vJ 1fSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10-v6si29326945pll.275.2018.06.09.01.35.33; Sat, 09 Jun 2018 01:36:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbeFIIez (ORCPT + 99 others); Sat, 9 Jun 2018 04:34:55 -0400 Received: from mail.CARNet.hr ([161.53.123.6]:59117 "EHLO mail.carnet.hr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753178AbeFIIey (ORCPT ); Sat, 9 Jun 2018 04:34:54 -0400 X-Greylist: delayed 1324 seconds by postgrey-1.27 at vger.kernel.org; Sat, 09 Jun 2018 04:34:53 EDT Received: from cnzgrivvl-t440p.carpriv.carnet.hr ([161.53.12.131]:39640 helo=gavran.carpriv.carnet.hr) by mail.carnet.hr with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1fRYzN-0005ZX-1b; Sat, 09 Jun 2018 10:12:45 +0200 Received: by gavran.carpriv.carnet.hr (Postfix, from userid 1000) id CF486246EE; Sat, 9 Jun 2018 10:12:44 +0200 (CEST) Date: Sat, 9 Jun 2018 10:12:44 +0200 From: Valentin Vidic To: Hugo Lefeuvre Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org Message-ID: <20180609081244.GP14048@gavran.carpriv.carnet.hr> References: <20180602175649.GA2816@hle-laptop.local> <20180607124216.GA2329@hle-laptop.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180607124216.GA2329@hle-laptop.local> User-Agent: Mutt/1.9.5 (2018-04-13) X-SA-Exim-Connect-IP: 161.53.12.131 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on rigel.CARNet.hr X-Spam-Level: X-Spam-Status: No, score=-2.9 required=10.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.2 Subject: Re: [PATCH v2] staging: pi433: add mutex fixing concurrency issues. X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 07, 2018 at 08:45:03AM -0400, Hugo Lefeuvre wrote: > After discussing this issue on the kernel newbies mailing list[0] we > came to the conclusion that it is very unlikely that pi433_release and > pi433_ioctl would ever run concurrently in this case. This is also > true for read/write. Unless one can find a situation where this might > happen, I think we should not add this potentially unnecessary lock. Yes, so we should than drop the TODO comment on this issue? -- Valentin