Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1975394imm; Sat, 9 Jun 2018 05:33:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKN69BLpc+d6ybFkdQQJHweIFsk58fSdD4TzL780JhWLGFNRDujjjBoOO11jPxUjDgbJJC3 X-Received: by 2002:a62:9c9c:: with SMTP id u28-v6mr10128591pfk.90.1528547597910; Sat, 09 Jun 2018 05:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528547597; cv=none; d=google.com; s=arc-20160816; b=gX+qq4DKJ62z7Twh4d6X7EKbdprGQPnYzN49Y+mHjTtt9RsLA8SN0rUtQnx0cRgyi7 ArXIj+Po+TZJjfnT7679K7RnZgYg3p9gA42HuO0Kf75TEjuzKt7daP9s9O6+fQSdoreD Qs1pdqj/eXt3br1k+xIqjyhSkFo5yGziTY4vKAFImBykKe/L4j8gqYeZTfO1H6PljK8l NWmou45e97PrOdR2IOzpnai81CQojaTFHvx+YsRqRkrtHIPWXAL34UElcVLKwVrDsRAP 7suANxEcUsEurHr5RpTGtOMUbKly0E0+tsMv4NPTxKZLpWIOUHa1bzCxH3EAuc52/0NU MssA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=pqhXNJaJwyeXksH/3YtMBJpMI4RrQHoXEsi/gXf88Pw=; b=tB7lQ9Xw9vOlnhQOE+5see/bENdP+RukW844w1IHHHnD7HPBXnCrAstNJMtOrNcje4 urghReWJG9RSCuTUycCw+XTD8v/MFwUjdqkUtD+fV0wVFrrmHwq/AVnaSuWxWrMN/iG+ SoF9gAM5Z4abJg8xnZMNz3213KGS4lc4zCebfmTAIHkcToRcvLW+raafvkXcwA9thmrS vspjdco9fOs5Gd/ixIf4AVPpl21jGEad2lvOgDW5wKDckX3uZ8uUqrIKrz5q64DD9ZPQ tLBksyR7iGtPLfxH/TmzxlRvs78JHmhYCVy+bk546v81MBwAf4m+vvrCV/0Gt2wUD39/ Foag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 90-v6si30006171plf.56.2018.06.09.05.33.02; Sat, 09 Jun 2018 05:33:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753325AbeFIMbH (ORCPT + 99 others); Sat, 9 Jun 2018 08:31:07 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44388 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753101AbeFIMbF (ORCPT ); Sat, 9 Jun 2018 08:31:05 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 922B24187E53; Sat, 9 Jun 2018 12:31:04 +0000 (UTC) Received: from localhost (ovpn-12-40.pek2.redhat.com [10.72.12.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 60B87210C6D4; Sat, 9 Jun 2018 12:30:55 +0000 (UTC) From: Ming Lei To: Jens Axboe , Christoph Hellwig , Alexander Viro , Kent Overstreet Cc: David Sterba , Huang Ying , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , "Darrick J . Wong" , Coly Li , Filipe Manana , Randy Dunlap , Christoph Hellwig Subject: [PATCH V6 02/30] block: bio_set_pages_dirty can't see NULL bv_page in a valid bio_vec Date: Sat, 9 Jun 2018 20:29:46 +0800 Message-Id: <20180609123014.8861-3-ming.lei@redhat.com> In-Reply-To: <20180609123014.8861-1-ming.lei@redhat.com> References: <20180609123014.8861-1-ming.lei@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 09 Jun 2018 12:31:04 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 09 Jun 2018 12:31:04 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ming.lei@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christoph Hellwig So don't bother handling it. Reviewed-by: Ming Lei Signed-off-by: Christoph Hellwig --- block/bio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/bio.c b/block/bio.c index 3e7d117c3346..ebd3ca62e037 100644 --- a/block/bio.c +++ b/block/bio.c @@ -1634,10 +1634,8 @@ void bio_set_pages_dirty(struct bio *bio) int i; bio_for_each_segment_all(bvec, bio, i) { - struct page *page = bvec->bv_page; - - if (page && !PageCompound(page)) - set_page_dirty_lock(page); + if (!PageCompound(bvec->bv_page)) + set_page_dirty_lock(bvec->bv_page); } } EXPORT_SYMBOL_GPL(bio_set_pages_dirty); -- 2.9.5