Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2685130imm; Sat, 9 Jun 2018 22:51:30 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKsyjMncj3vgPj/W3PIEQ+VO8CVGq9vwXKE8UxYkv4w3bi/cjbAkhTqtrhAJBr+w++ZwiXp X-Received: by 2002:a62:d653:: with SMTP id r80-v6mr12578520pfg.54.1528609890307; Sat, 09 Jun 2018 22:51:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528609890; cv=none; d=google.com; s=arc-20160816; b=LlP/WPB1U4BhZO9RSh8Q1KxWl5HPTX2pYxGbZ9tTGor/M2i//8+aGooKuiiue9FiSc s4AZ996BqaveFrbhDIyZ/6G1D0j1rlUir5bSCmlen2HXUTPu0HJ5MY1d/ts4ZsgcjpqS vBfpMvSzHTmL2AFVq5XThcSS2X7saBXvjvjyqI+ajDOw5F6aplYKb5b71ThQbnoTqH7+ o3lJMWQfFgs8/ptEMJhF9mzY/XapTSc2g3s3o8gY5aAQO6NbUNJbrwD6Mg2+v7Iwj9Ex bw98q9WAJ5Hf5cwVWCAAeu65iN+xOlurjVv+YkyKdvWQ/HbfjegR/I29LP1Q98/gUEmU +PQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=jaUIkSmis2HI606lA79h4cCDsOWsLjjccEOxBDLL194=; b=rqEkU1/jX74+5vheQ691DjGU4qxLHXC31A/QEG/oJIeCg0q3FmHGGqfmcdN9OywVzy K6DeSyCoaYeEIWvfMRd02uqI7VfVKMv7jtBvDytHGhCOkz/1M+z2PkT6JDsRgrlhzF+a 7jzVplmQQZ6wPiu1vOs6xL8kjxKYAb9k2b6aEhZ+sATkd4yUinZ4H0Bver9I3FFNKaX/ d69YlBu5BsbOHmHMts4uToKKZHFIlkSPlEj+YmHycGvkbFlnNUBlRxPEKb/Jy/GSG9nL wBzeIUDK03lTbauK/gJ8TlwqHt/g5hpXdxz0MPP9SsrIDQFklM1/hWqE2bdRXa5uzoOR dloA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j7-v6si32603989plk.334.2018.06.09.22.51.14; Sat, 09 Jun 2018 22:51:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbeFJFtw (ORCPT + 99 others); Sun, 10 Jun 2018 01:49:52 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:54432 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbeFJFtv (ORCPT ); Sun, 10 Jun 2018 01:49:51 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fRtDy-00047R-RL; Sun, 10 Jun 2018 05:49:17 +0000 Date: Sun, 10 Jun 2018 06:49:10 +0100 From: Al Viro To: Miklos Szeredi Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/11] vfs: factor out inode_insert5() Message-ID: <20180610054902.GQ30522@ZenIV.linux.org.uk> References: <20180529144143.16378-1-mszeredi@redhat.com> <20180529144143.16378-10-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180529144143.16378-10-mszeredi@redhat.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote: > From: Miklos Szeredi > > Split out common helper for race free insertion of an already allocated > inode into the cache. Use this from iget5_locked() and > insert_inode_locked4(). Make iget5_locked() use new_inode()/iput() instead > of alloc_inode()/destroy_inode() directly. ... thus hitting the sucker with ->evict_inode(), in condition that is quite likely to be unfit to be seen by that. NAK.