Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 10 Jun 2018 07:02:15 +0100
From:   Al Viro <viro@ZenIV.linux.org.uk>
To:     Miklos Szeredi <mszeredi@redhat.com>
Cc:     linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] vfs: factor out inode_insert5()
Message-ID: <20180610060159.GS30522@ZenIV.linux.org.uk>
References: <20180529144143.16378-1-mszeredi@redhat.com>
 <20180529144143.16378-10-mszeredi@redhat.com>
 <20180610054902.GQ30522@ZenIV.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180610054902.GQ30522@ZenIV.linux.org.uk>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 10, 2018 at 06:49:10AM +0100, Al Viro wrote:
> On Tue, May 29, 2018 at 04:41:41PM +0200, Miklos Szeredi wrote:
> > From: Miklos Szeredi <miklos@szeredi.hu>
> > 
> > Split out common helper for race free insertion of an already allocated
> > inode into the cache.  Use this from iget5_locked() and
> > insert_inode_locked4().  Make iget5_locked() use new_inode()/iput() instead
> > of alloc_inode()/destroy_inode() directly.
> 
> ... thus hitting the sucker with ->evict_inode(), in condition that is quite
> likely to be unfit to be seen by that.
> 
> NAK.

To clarify: objection here is against the switch to new_inode/iput.  The rest is
sane.  What makes new_inode() better here, anyway?