Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Jun 2018 10:03:14 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Nadav Amit <namit@vmware.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v3 4/9] x86: alternatives: macrofy locks for better
 inlining
Message-ID: <20180611080314.GR12258@hirez.programming.kicks-ass.net>
References: <20180610141911.52948-1-namit@vmware.com>
 <20180610141911.52948-5-namit@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180610141911.52948-5-namit@vmware.com>
User-Agent: Mutt/1.9.5 (2018-04-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 10, 2018 at 07:19:06AM -0700, Nadav Amit wrote:
>  #ifdef CONFIG_SMP
> +.macro LOCK_PREFIX_HERE
>  	.pushsection .smp_locks,"a"
>  	.balign 4
> +	.long 671f - .		# offset
>  	.popsection
> +671:
> +.endm
> +
> +.macro LOCK_PREFIX insn:vararg
> +	LOCK_PREFIX_HERE
> +	lock \insn
> +.endm

Hurmph, the only reason we need to preserve that LOCK_PREFIX_HERE thing
is arch_cmpxchg64 in cmpxchg_32.h. Is there really no other way we can
write that one?

I suppose the problem with using LOCK_PREFIX inside the alternative is
that the .smp_locks fixup address gets computed wrong (inside the
alternative_text section instead of in the regular text)?

Oh well..