Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3970076imm; Mon, 11 Jun 2018 05:02:05 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKQSaabFQ2/gAxUiFqxE8zYZaaiKwSPX3+R5d+HoxPw7AHYQajgZFBYPYB5kTspgysMvg0W X-Received: by 2002:a62:32c6:: with SMTP id y189-v6mr17295955pfy.241.1528718525439; Mon, 11 Jun 2018 05:02:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528718525; cv=none; d=google.com; s=arc-20160816; b=1GPx/ZmMwGY85rrflVqnQ+Mg7QUEqUn/dEK7v1fQBo4lXPQDP8DTg4BW7c6UunAaP3 LPZlgpV3dvtOlDO0OHHPudTgDvFIRW5qQTPa9P8ekmkkU7TJe9CLubKeJ1kiiS0twD+L 9gIpvnzISsRe9PWQB0pb1ukkQnY5juJAc34wDXaNPjoTi2VSc4hAVPFiAMsvh+jPqJf4 /g7jDSIaifAvUBswbpwiFFjcxoZPLbXIacz/uRZL0GROJUVwDyMQXb92wC5uWjWw52Q8 02m68BEcH87Q1uOKHzu/J1sxN62xdVeg1BXUtGZSt7pCS2hNDvNfacX2mCPBzyOPRF8u 4TGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=xdLxjk0Q8O47kyIPh0dVVd/xYllcF+e5dBFDiji/Cmk=; b=UR6C4FjN9yzq54fP8kVqzT711fjNziLRe00kvwAVTejGe+tqmvANo/ZU+q5oYyGhUW +Rg1syB6de09d5bT0VwNrrW1GXObDE/7qVB0DkijkpGTKT7AD36pBQKVuEmGmpWXTz6C OCgEdJJoAVIJkkJcCYCKAYXeJQwLbztqa9B64vmkFo4F+wJ6BJPfDCHVbK+dBY9bi38+ Pc4Ii3vhCZKszyrvsHzshZuHiXGGzpwahOjaQ1/XmBUeONmfpwzlpN/EXoOZXBL/UkJF UFUrDvU+2RtOWC192FSM/t8Ac5UX2QCO9NUZFKZCcq0fdzRp4BWRQVTX1Q1H7xRqpPtI 9npQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GVUQFYPm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l21-v6si12328888pfk.321.2018.06.11.05.01.50; Mon, 11 Jun 2018 05:02:05 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GVUQFYPm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933037AbeFKMB1 (ORCPT + 99 others); Mon, 11 Jun 2018 08:01:27 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:46429 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933356AbeFKL7O (ORCPT ); Mon, 11 Jun 2018 07:59:14 -0400 Received: by mail-wr0-f196.google.com with SMTP id v13-v6so20098616wrp.13; Mon, 11 Jun 2018 04:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xdLxjk0Q8O47kyIPh0dVVd/xYllcF+e5dBFDiji/Cmk=; b=GVUQFYPmQD3jvB/0oVamN8/djGlsHatemNoySupUZEH6j/ObCO3LH0cF6n9VCnPWGa 7p4SK2dDrmQSqaspmBGp1vNx3Zb93VtscXOS3oDFdJTK9RCmZxASfXRvS0fx5rHb3hCX 0fC443DjFmDjfjf+LBPW8oNZHmSUheR+7dnZpY95h1khxbT6Mf7no81VATyUe0lpXY1L uwoMbLVv8zrlndMMQ2B5sbPFqLKlsS0RCA77h5wFl3IGn/4gSgsjsWWHTRg98otE2BZQ ZR2r8nO1JMiZ28bBdAlJLp01zgtMYwnZC6UBddw0ISptBKz23FDVPeJ8hC4r547qxiC5 LSKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xdLxjk0Q8O47kyIPh0dVVd/xYllcF+e5dBFDiji/Cmk=; b=o1K5caaPnSvRYxVgTqAr60ABp4fmC3J/LFsshq87z3FEY6QQ6M10wVHqJnOlNrKKkY aFndFbd3720jJMSzq1ujQTnE0F8Z54WmyQKtWSjUkaFQjl73vVziSc+YHy7ulvPCZ/Ia AqqAnJJrke0kcRPpfrWT1r422LF+RjKTv7ZsucQpfqQwQYdDKgWDAUvcaQNe/FxkY9FI HtUBKCrJQqd2jeOvVpCRMbmjKK+Dqx830LQy7xxl3zx5ngj4NMMpqK474xZXED5L5RFV jxTV/HjZjQZJRsfFrv2Epxud0ctRYBYag+SoC/p3jNqq9CagXIfQln8e0G8AzYYbUHPv zcsw== X-Gm-Message-State: APt69E2u8NT0zQqz6+fxTWoBGvGKVdBegx2qR9GdNJ96KqMy514UYOy7 D0oKgWfrs9mh2fDyBkT7to5Toya+ X-Received: by 2002:adf:8462:: with SMTP id 89-v6mr13948387wrf.138.1528718352720; Mon, 11 Jun 2018 04:59:12 -0700 (PDT) Received: from kurokawa.lan (ip-86-49-107-50.net.upcbroadband.cz. [86.49.107.50]) by smtp.gmail.com with ESMTPSA id t124-v6sm7974796wmt.29.2018.06.11.04.59.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 04:59:11 -0700 (PDT) From: Marek Vasut X-Google-Original-From: Marek Vasut To: linux-kernel@vger.kernel.org Cc: Marek Vasut , Geert Uytterhoeven , Lee Jones , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: [PATCH v6 07/14] mfd: da9063: Rename PMIC_DA9063 to PMIC_CHIP_ID_DA9063 Date: Mon, 11 Jun 2018 13:58:44 +0200 Message-Id: <20180611115851.1987-7-marek.vasut+renesas@gmail.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180611115851.1987-1-marek.vasut+renesas@gmail.com> References: <20180611115851.1987-1-marek.vasut+renesas@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The PMIC_DA9063 is a complete misnomer, it denotes the value of the DA9063 chip ID register, so rename it as such. It is also the value of chip ID register of DA9063L though, so drop the enum as all the DA9063 "models" share the same chip ID and thus the distinction will have to be made using DT or otherwise. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Lee Jones Cc: Mark Brown Cc: Steve Twiss Cc: Wolfram Sang Cc: linux-renesas-soc@vger.kernel.org Acked-by: Mark Brown Reviewed-by: Geert Uytterhoeven Acked-for-MFD-by: Lee Jones Acked-by: Steve Twiss --- V2: No change V3: No change V4: No change V5: No change V6: No change --- drivers/mfd/da9063-core.c | 2 +- drivers/mfd/da9063-i2c.c | 2 +- drivers/regulator/da9063-regulator.c | 2 +- include/linux/mfd/da9063/core.h | 4 +--- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/da9063-core.c b/drivers/mfd/da9063-core.c index f57558590283..c54777cc2f12 100644 --- a/drivers/mfd/da9063-core.c +++ b/drivers/mfd/da9063-core.c @@ -192,7 +192,7 @@ int da9063_device_init(struct da9063 *da9063, unsigned int irq) dev_err(da9063->dev, "Cannot read chip model id.\n"); return -EIO; } - if (model != PMIC_DA9063) { + if (model != PMIC_CHIP_ID_DA9063) { dev_err(da9063->dev, "Invalid chip model id: 0x%02x\n", model); return -ENODEV; } diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c index e9797153bc19..d1fe88777e3f 100644 --- a/drivers/mfd/da9063-i2c.c +++ b/drivers/mfd/da9063-i2c.c @@ -181,7 +181,7 @@ static int da9063_i2c_probe(struct i2c_client *i2c, } static const struct i2c_device_id da9063_i2c_id[] = { - {"da9063", PMIC_DA9063}, + { "da9063", PMIC_CHIP_ID_DA9063 }, {}, }; MODULE_DEVICE_TABLE(i2c, da9063_i2c_id); diff --git a/drivers/regulator/da9063-regulator.c b/drivers/regulator/da9063-regulator.c index 6a8f9cd69f52..87c884ae0064 100644 --- a/drivers/regulator/da9063-regulator.c +++ b/drivers/regulator/da9063-regulator.c @@ -585,7 +585,7 @@ static struct da9063_dev_model regulators_models[] = { { .regulator_info = da9063_regulator_info, .n_regulators = ARRAY_SIZE(da9063_regulator_info), - .dev_model = PMIC_DA9063, + .dev_model = PMIC_CHIP_ID_DA9063, }, { } }; diff --git a/include/linux/mfd/da9063/core.h b/include/linux/mfd/da9063/core.h index 260cd5834861..e015b065db7e 100644 --- a/include/linux/mfd/da9063/core.h +++ b/include/linux/mfd/da9063/core.h @@ -29,9 +29,7 @@ #define DA9063_DRVNAME_RTC "da9063-rtc" #define DA9063_DRVNAME_VIBRATION "da9063-vibration" -enum da9063_models { - PMIC_DA9063 = 0x61, -}; +#define PMIC_CHIP_ID_DA9063 0x61 enum da9063_variant_codes { PMIC_DA9063_AD = 0x3, -- 2.16.2