Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Jun 2018 15:26:02 +0200
Message-ID: <s5hlgblbgk5.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Zhouyang Jia" <jiazhouyang09@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Bhumika Goyal" <bhumirks@gmail.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: sonicvibes: add error handling for snd_ctl_add
In-Reply-To: <1528704521-34060-1-git-send-email-jiazhouyang09@gmail.com>
References: <1528704521-34060-1-git-send-email-jiazhouyang09@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 11 Jun 2018 10:08:40 +0200,
Zhouyang Jia wrote:
> 
> When snd_ctl_add fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling snd_ctl_add.
> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>

I postpone this one because the change won't give anything as is
although this change itself is correct.  If you look at the code
closely, the caller of snd_sonicvibes_create_gameport() ignores the
return value.
So we need to fix two places.


thanks,

Takashi