Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4118505imm; Mon, 11 Jun 2018 07:18:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLPOL/8Z9EdgTN6VkuzCY/E0q1OhAXZeIDeH7G6xzd/Wa81wCNkRj7J5Vclz+XZ0zLB/t5Z X-Received: by 2002:a17:902:1025:: with SMTP id b34-v6mr18860408pla.207.1528726688558; Mon, 11 Jun 2018 07:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528726688; cv=none; d=google.com; s=arc-20160816; b=QXK9PNX4ALklzIe77jaSAvm+uLr+8yRE+M2FCFPT0S3x1F+UzgSeAslaHYuwG4BtKq NXcvOti2SiNS4qkBe14R9dBhelg/r7cerrFF+Ywa4gs1l3+2K8sMVHgCID3NWwjZ362W cX33/uiLsNqtXRHlSO2+BllHCsYNirH921JqnIppzz7LcTEhvHuqnV0v7tIVx5rTnb7z JceynBAyEN0JzAQtcc4rhv/K7yPOHrBnCvfOvv4bptlQnhXiBCIjs6Q/koMYlsbSUiuy CsSr6yv1OxjrUvKZ9vbSrwwj2aA/rAvk5ykebQnGNgRiEiJLqs767l9sH8enNjl8Fmse Bb7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=03oZkn2Dig9Go7txwjOMirSKiDNMujPUnOoSMnC/gDE=; b=k7X2uafIzaOKAnNGTu41puZ5VH8bqWKW3XaWR/lW/OIR6EHDTtLRbduFLBs1tHYWzT +ffUzrLQSdhZP6eaHRNJ6N6f5MUsQ7FVzCn7koQqU8p33PaSMoMeS9u88nI9/JGSjQmj 0g6eF/JRhZGFklrleegaTGV4Wl1fjNR52ZoWe2axyWf/ANJ7JmN2V0fosyiHcSPjXGdk 6wUL+ubREomSQyv0dRLOJIgtToSFMugItnNc+jddfM15bIRcqSzPVrOT3SngQiJtYduu /dc1v4Yx3iSZtUwjpoBwMX8nooS57Wfhfa9kw5upwzitc0z1IdoY4iWRvj0sPNLYflok m5rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@cmpxchg.org header.s=x header.b=e6XWf3be; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z25-v6si1837964pfg.184.2018.06.11.07.17.54; Mon, 11 Jun 2018 07:18:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@cmpxchg.org header.s=x header.b=e6XWf3be; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934107AbeFKORM (ORCPT + 99 others); Mon, 11 Jun 2018 10:17:12 -0400 Received: from gum.cmpxchg.org ([85.214.110.215]:54134 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933534AbeFKORJ (ORCPT ); Mon, 11 Jun 2018 10:17:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=cmpxchg.org ; s=x; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=FEkErDQ6hAFvizy8B/F5+8tRwr//SvGo6GUoksXzhWk=; b=e6XWf3bew3jwBsUehAA5s8PzHj UHhMA40XeEeBoEkvyEMsyv/tnWbe6jr4KTzmJwfCmqKo3TvSxRPLWnPmmqT6W7dF0uz451MQ0VueD 6oF5k4qLexUsKLXvZK2evfTt3ImJAjSM8MCZcWFvIvrjSqMtG0dStXncR8W4aQEBV/pk=; Date: Mon, 11 Jun 2018 10:19:25 -0400 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , Shakeel Butt , linux-mm@kvack.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH] mm: fix null pointer dereference in mem_cgroup_protected Message-ID: <20180611141925.GC1507@cmpxchg.org> References: <20180608170607.29120-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180608170607.29120-1-guro@fb.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 08, 2018 at 06:06:07PM +0100, Roman Gushchin wrote: > Shakeel reported a crash in mem_cgroup_protected(), which > can be triggered by memcg reclaim if the legacy cgroup v1 > use_hierarchy=0 mode is used: ... > Reported-by: Shakeel Butt > Signed-off-by: Roman Gushchin > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Andrew Morton Acked-by: Johannes Weiner