Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: thor.thayer@linux.intel.com
Subject: Re: [PATCH V2] EDAC, altera: Fix an error handling path in
 'altr_s10_sdram_probe()'
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>, bp@alien8.de,
        mchehab@kernel.org
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
References: <20180610174532.22071-1-christophe.jaillet@wanadoo.fr>
From:   Thor Thayer <thor.thayer@linux.intel.com>
Message-ID: <092ce90c-1f68-1041-4385-997dcb13bc22@linux.intel.com>
Date:   Mon, 11 Jun 2018 09:53:53 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180610174532.22071-1-christophe.jaillet@wanadoo.fr>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06/10/2018 12:45 PM, Christophe JAILLET wrote:
> IF 'regmap_write()' fails, we should release some resources as done in all
> the other error handling paths of the function.
> 
> Fixes: e9918d7fafae ("EDAC, altera: Handle SDRAM Uncorrectable Errors on Stratix10")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> v1 -> v2: Fix subject line
> ---
>   drivers/edac/altera_edac.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index d0d5c4dbe097..5762c3c383f2 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c
> @@ -730,7 +730,8 @@ static int altr_s10_sdram_probe(struct platform_device *pdev)
>   			 S10_DDR0_IRQ_MASK)) {
>   		edac_printk(KERN_ERR, EDAC_MC,
>   			    "Error clearing SDRAM ECC count\n");
> -		return -ENODEV;
> +		ret = -ENODEV;
> +		goto err2;
>   	}
>   
>   	if (regmap_update_bits(drvdata->mc_vbase, priv->ecc_irq_en_offset,
> Thanks.

Reviewed-by: Thor Thayer <thor.thayer@linux.intel.com>