Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 11 Jun 2018 17:30:42 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Jeremy Cline <jeremy@jcline.org>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        rui.zhang@intel.com, len.brown@intel.com, stable@vger.kernel.org,
        linux-kernel@vger.kernel.org, regressions@leemhuis.info,
        Diego Viola <diego.viola@gmail.com>
Subject: Re: Regression: x86/tsc: Fix mark_tsc_unstable()
Message-ID: <20180611153042.GI12235@hirez.programming.kicks-ass.net>
References: <01000163ef24c875-daa2c00e-611e-4383-99a6-c8c72ef04a14-000000@email.amazonses.com>
 <20180611141742.GP12198@hirez.programming.kicks-ass.net>
 <20180611143801.GH12235@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180611143801.GH12235@hirez.programming.kicks-ass.net>
User-Agent: Mutt/1.9.5 (2018-04-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 11, 2018 at 04:38:01PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 11, 2018 at 04:17:42PM +0200, Peter Zijlstra wrote:
> > On Mon, Jun 11, 2018 at 01:59:15PM +0000, Jeremy Cline wrote:
> > > A user has bisected the problem to the v4.16 commit 1ab4ca7c59d4
> > > ("x86/tsc: Fix mark_tsc_unstable()"). According to the reporter,
> > > explicitly setting "tsc=" on the kernel command line causes the boot to
> > > always succeed. All the users have Thinkpad T500s or T400s (Core 2 Duos)
> > 
> > Weird. So Core2 typically triggers mark_tsc_unstable() in either
> > intel_idle or processor_idle. ISTR testing that when I did the patches.
> > 
> > When I make that mark_tsc_unstable() in the idle drivers unconditional
> > and boot my ivb with that, it doesn't want to fail. I've booted the
> > machine 5 consequctive times without issue.
> > 
> > Let me try and checkout -stable, maybe something's up with that.
> 
> Nope -stable seems to be working as well on the IVB (with modification).
> I just dug up my T500 and that's actually still running the test kernel.
> Let me try and build the -stable kernel for that.

4.16.8 works without issue on my T500 with a debian/ubuntu like distro
config.