Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4330830imm; Mon, 11 Jun 2018 10:28:27 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI0r7E7C1rpr/yG0UQ5frYJSLPjLHxblBi2CHWUcysSTDTzoF5sRHp19CrfvtKwN7077Of4 X-Received: by 2002:a17:902:1e4:: with SMTP id b91-v6mr73734plb.155.1528738106995; Mon, 11 Jun 2018 10:28:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528738106; cv=none; d=google.com; s=arc-20160816; b=txoTaOlZJ9rAK3pbXY6B14g5yU3aKQmEnD8BydqsUpWHtozCWPNm59SsBBztxXWQfB TGDG8uSFGRLceBcF/FmiC+jr9c1OgBqChbWswpJe6U7/7aKDujKy1QpG2Wqi/ESxC4n9 PuxrIMF4Kr5gaTDV0ya7s6R9IwzeTsQT9SBPiCfFIXe1Spw6BFjMYcl03bqM/fHQ9A8c A42IJlfD3KZa98KXA7ohgBptEbe299nSSdI/A7MLDuSAU5dnKAiBZ1Yqy6wOgsZsjncT hEDncJ+kdKI9v/yrndpwScOFL55A9CODnMWLfR5TxOQXFzkunEiDGKCXvIfamul13mvI L2Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=ji1MZmi3qf1UF67FG8Q+8qrsQTP0irFyIVZ7ybYJqcc=; b=NIEyDzkgH+oea2/o2oGNamF2klHjDI/TZnuvo2i7pbeyf4Qpq2AXBQbWnbEtwChEaA oJ+sdiHDiz1PekVCV4pG7ZsVgRJr711Ron74LsUis+8P6OJ+jJ5p46V811StrkSXUEP6 O6MvV4l9OAAjtYz/2FZMYQR86kJ8tx339jfO78hEdpSQTwIUcug6pxnw8S8yAuiLyFH7 m3nmnwsfvVedLA0bqUpBPE/tuvUnaGJmy1FGAQdf8Y0c8GYLxKWcwf6wWjFCmlCa/mvS HAvq7zMINrqE8kfz7Ddh4qus9KAp3W8IZiIHccjQzc4QgnH2uxAHKdaU1MtAsr9sRhk2 cI3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XgeNG2Z4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s23-v6si39138684pfi.105.2018.06.11.10.28.12; Mon, 11 Jun 2018 10:28:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=XgeNG2Z4; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933465AbeFKQYZ (ORCPT + 99 others); Mon, 11 Jun 2018 12:24:25 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933436AbeFKQYQ (ORCPT ); Mon, 11 Jun 2018 12:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ji1MZmi3qf1UF67FG8Q+8qrsQTP0irFyIVZ7ybYJqcc=; b=XgeNG2Z4Kyp0D9TjRuqRJ7hh5 aQcO62H0ArbCxkOjO0ehtTT2gw3Yrp8FTaPZk1SwBXpcFr3Gl5pliYlCYlrhiaXjlwA35wzoVNpJo Ml3Nk8Nu8f/MO3FLBbpJoi4PrpqUS+EjCdYeNNk00R6OBGd5wOcR4spcWHexg1kgAKMKFekkVyqW5 WV6cIlA7/jf7LS2LtQYMqSPSIyAFfwjp8Ml0g3opPchNbauRhTT1z1d2CnoqH0G1oIoQGx9BkLVrt bDpf6Mqe6+I9Tt7Biw0p4OuaGKvXfjCqOVTbQccVdDDJEys1NBo+OQ9xlyAmdBI8W9US2AEF82MiI h7PrBy/Ig==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSPc5-0002wB-C6; Mon, 11 Jun 2018 16:24:13 +0000 Date: Mon, 11 Jun 2018 09:24:12 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: Al Viro , Christoph Hellwig , Miklos Szeredi , overlayfs , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules Message-ID: <20180611162412.GA7574@infradead.org> References: <20180529144339.16538-1-mszeredi@redhat.com> <20180529144339.16538-8-mszeredi@redhat.com> <20180604084904.GF11333@infradead.org> <20180610045657.GM30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 11, 2018 at 09:19:01AM +0200, Miklos Szeredi wrote: > We don't. Obviously need to make sure to only ever do ioctl's in > overlayfs that have a common definition across filesystems. Not a lot > of those, luckily... Which are those? If they are common and possibly called from kernel code they should probably be made into methods instead.