Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4657279imm; Mon, 11 Jun 2018 16:47:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLnWijOZhob3q93WmUgafmHVvDocUga4AA/Cwrg6aod/Bb5GDuOQDnZmCzEus0qSOGsmHa1 X-Received: by 2002:a65:6008:: with SMTP id m8-v6mr1074083pgu.134.1528760846433; Mon, 11 Jun 2018 16:47:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528760846; cv=none; d=google.com; s=arc-20160816; b=bCNkgsMBIIszBQmYJJpK8M9L8PjBADPkD5miWSCBoxQe0P3D1P8VsLE5adi6Ntuj0A b82FPJc/ypLuB6h+gas38HPaVc1kungfy4EepNboKv+MpH1tSqQEZJ+MuStJWTIaZe5/ Ts4bG86JsiVcM4d9ARFQBlZvq4M0CjOhHvSWGIpT4ZKxzPzygj/MZGjqNh+GJTrSP/2d 5x+NpRrSwJfoBre92KYMMLyzSzutW+ZZQht8cX3eGOLJYM5kS9uiAfWpMnWESmEWa21K ALIw2LmSlqvSgSDO3CjoAQzI9dXCfEkoka2fLdebShwV2B+yFXky2aGgdQ3JBmPu7Cvm /O9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date:arc-authentication-results; bh=lcoszC2uglXxrMoMjU98t7dtdcl5wFJUnSXolSvngVM=; b=xB7qkNdnBfLhORl5K9WUQokQuw/VjrPoonNW4r3T+djo/nvtGiZAbmRdZIjCrfGyw+ iHBq8Aq67MMCUOAPszBkK+BpjquigNmyR0GUEdJPRVYbtm7Zd7+6Z7lyf16YSi/nk+Rr yQIPYc+I4Bfcj4vVDhm0l5hm3cqTLWcsl8W1gRpFvgJ2yVvkpNl1P04fLmKGjQb8oH0S PsNf8AlH5+YcPkJYfI188J9+mSAOMwvA+mTCiwGotcVqqg/nFsIi55DTJW9gmJKaJp3q 0C78SoAD7ft4d14I0K3bk3+TrJEyW7eqG1aAL7hP0PvsQ78UxMFJGWBXh7yXpZNxMrPn 0x8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c8-v6si25021080pgn.473.2018.06.11.16.47.11; Mon, 11 Jun 2018 16:47:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933495AbeFKXqr (ORCPT + 99 others); Mon, 11 Jun 2018 19:46:47 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:53202 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932471AbeFKXqq (ORCPT ); Mon, 11 Jun 2018 19:46:46 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by kvm5.telegraphics.com.au (Postfix) with ESMTP id B588228FD5; Mon, 11 Jun 2018 19:46:39 -0400 (EDT) Date: Tue, 12 Jun 2018 09:47:06 +1000 (AEST) From: Finn Thain To: Benjamin Herrenschmidt cc: Michael Schmitz , Andreas Schwab , linuxppc-dev@lists.ozlabs.org, linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Laurent Vivier Subject: Re: [PATCH v2 08/12] macintosh/via-pmu68k: Don't load driver on unsupported hardware In-Reply-To: <3490f7d6f45ec2586858e4547e97474d93bd2d4d.camel@kernel.crashing.org> Message-ID: References: <9f015684-4d91-70e4-d2a4-89fe167ff8ab@gmail.com> <3490f7d6f45ec2586858e4547e97474d93bd2d4d.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 10 Jun 2018, Benjamin Herrenschmidt wrote: > Pre-PCI is basically "NUBUS" based even in absence of an actual NuBus > slot :-) It has to do with the internal HW architecture. The only ones > that aren't are the even older designs (the 68000 based ones). > There is already some disagreement in the comments in the nubus-pmac code about the suitability of "PMU_NUBUS_BASED" as opposed to e.g. "PMU_WHITNEY_BASED". Point is, the PMU driver doesn't care about the expansion slots or architecture (Whitney-based PMU appears on m68k and powerpc). So NuBus vs. PCI is a red herring here. The pmu_kind relates to backlight, buttons and battery. (Leaving aside the PMU driver, if a pre-OpenFirmware Mac has a "slot zero" ROM, one can argue that it is actually a NuBus machine, regardless of any actual expansion slots.) > What's the situation with those NuBus things ? What do they use as a > bootloader ? The old Apple one or BootX ? We should merge that port of > it's maintained. > I agree that this code should not languish out-of-tree. But it would need more work before it could reasonably be submitted to reviewers. I do have some nubus-pmac hardware but I also have more mac/68k driver work to do before I can tackle another architecture. I don't know what the bootloader situation is, but it looks messy... http://nubus-pmac.sourceforge.net/#booters Laurent, does Emile work on these machines? -- > Cheers, > Ben. >