Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <mhng-7a581ed4-d7ab-4188-92e6-3a8002f3c8d1@palmer-si-x1c4>
References: <20180611214822.8539-1-jimw@sifive.com> <mhng-7a581ed4-d7ab-4188-92e6-3a8002f3c8d1@palmer-si-x1c4>
From:   Jim Wilson <jimw@sifive.com>
Date:   Mon, 11 Jun 2018 20:27:52 -0700
Message-ID: <CAFyWVaawEbKmccfRsFiooJeGxX6P4xDXqvWiCyiJnfTAK2g0pA@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Fix PTRACE_SETREGSET bug.
To:     Palmer Dabbelt <palmer@sifive.com>
Cc:     linux-riscv@lists.infradead.org, Oleg Nesterov <oleg@redhat.com>,
        Albert Ou <albert@sifive.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 11, 2018 at 5:46 PM, Palmer Dabbelt <palmer@sifive.com> wrote:
> Whoops, that's embarassing :).  I poked around and didn't see this anywhere
> else, so I'm not sure where we managed to obtain this particular pathology.

Comment say it was copied from tile which I think was just recently
removed.  But looking at older copy, tile has "struct pt_regs regs"
whereas riscv has "struct pt_regs *regs" and so tile needed the & and
riscv does not, but only one of the two ampersands was removed in the
riscv port.  My patch removes the other one.

Jim