Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp4843091imm; Mon, 11 Jun 2018 20:56:51 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLwLYiuJP3s8WkV4Dlap1ws/7NbRV54kaDH95OkqSiSAJWRvnS0/SjXvYgfAsBQxw9IYxO8 X-Received: by 2002:a17:902:758e:: with SMTP id j14-v6mr2089949pll.160.1528775811782; Mon, 11 Jun 2018 20:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528775811; cv=none; d=google.com; s=arc-20160816; b=ixyDp/dDenYrH6jXJ0oXEOmOuVRyuE5+hgw21yOb5Dm2iXrxAauRyipBl0SSaCmURh p/Plqkp4Ef2WuQtWgjjvJhNJTjEHETJJOp1FWQafh0PrmMWdG0LDKUw61Qdp++ZLXbS+ Q+0+Spb37W2u7wUjSjUdLEXvPxjKoDk1q846ZugL8mlwE9qbDvkBAUAP7xcCnAnYaDev NJR23AZp4wXkVge4MYW+FRaMPrjSp3MkKG8c4gNBizIyHJcRWZqq8NK8uQnznYbUNGjF ZO9HvKXfPeGal+iF6ZHANZTpun7XjVFwMLISUjGZ16uaFgkhMz86+L1Q4XzF9veTPpeF WTtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-id:spamdiagnosticmetadata:spamdiagnosticoutput :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=wpzw/2jCTEvvTCvKMgv9Pa0yW19f9bW47AIcGvgfWzs=; b=HNRtrmxNUvwX8+UHgaJCr2qe46cdikfLO9Fno7KPIUfH9/nth5AXnKBQBK56WtA9I4 VAP3Uk9SnQTbO0SEQG5/Hheq5vBjT9g8n4jd2zu4nxSRYu9XVSBFtYyb4QblonT1I1Zl TpoExXvK4meVZX+nKmnw7XkxwUABijtQ02Y9THWZfbx8lLDissJFKaG5Dz6imPZHXC/6 0Np2dHhzMwweOOSw4aafk8w4CGceUf3+XnQ/a/CFnpjwzNOYW4irZ8+4+tMkXv3QauBv QzVRZV5qfcW2SBvLBbipfjI2GuQiNmKpFJ//nFNuBZ4Viql3o2GWbEQBMHx/juiCXMl7 1mCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@vmware.com header.s=selector1 header.b=b0wP3BQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vmware.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9-v6si24535689pfa.368.2018.06.11.20.56.36; Mon, 11 Jun 2018 20:56:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@vmware.com header.s=selector1 header.b=b0wP3BQl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=vmware.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933507AbeFLDtm (ORCPT + 99 others); Mon, 11 Jun 2018 23:49:42 -0400 Received: from mail-dm3nam03on0046.outbound.protection.outlook.com ([104.47.41.46]:18080 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933182AbeFLDtl (ORCPT ); Mon, 11 Jun 2018 23:49:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vmware.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wpzw/2jCTEvvTCvKMgv9Pa0yW19f9bW47AIcGvgfWzs=; b=b0wP3BQla7y+6IiMGEdIRPNhLp31ETyhzhH5Dh+NgnNaQ6jGBWsLce1fw5oj7Ve6mw5T3EkDc4PHcaOmb+y7cd3ffSqfTVqGRtxFwZGJpL5141bHPhhFNKPmMIv1UNk74iHvENMRipfSyqtgmUMI+c6nbTJj6uB5wXXMJPtT1Dw= Received: from BYAPR05MB4776.namprd05.prod.outlook.com (52.135.233.146) by BYAPR05MB4325.namprd05.prod.outlook.com (52.135.202.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.841.12; Tue, 12 Jun 2018 03:49:38 +0000 Received: from BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::1010:9926:76ba:c7b7]) by BYAPR05MB4776.namprd05.prod.outlook.com ([fe80::1010:9926:76ba:c7b7%2]) with mapi id 15.20.0863.016; Tue, 12 Jun 2018 03:49:38 +0000 From: Nadav Amit To: Peter Zijlstra CC: Linux Kernel Mailing List , the arch/x86 maintainers , Juergen Gross , Alok Kataria , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops Thread-Topic: [PATCH v3 6/9] x86: prevent inline distortion by paravirt ops Thread-Index: AQHUAQLqACZiCEpusUWZ3JiviOyuwKRarjWAgAFQh4A= Date: Tue, 12 Jun 2018 03:49:37 +0000 Message-ID: References: <20180610141911.52948-1-namit@vmware.com> <20180610141911.52948-7-namit@vmware.com> <20180611074507.GP12258@hirez.programming.kicks-ass.net> In-Reply-To: <20180611074507.GP12258@hirez.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [208.91.2.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;BYAPR05MB4325;7:9bWlCyvQ+kNCe3B/k8hg2+FaWBrAkpVpi0MidruIcHY952gKer4v/HkPo8z4P43ba/Tv1bTPnq0zjeCCJUaHY36zopLpcj0Ofs0DutEe62W1EQWl1snLYTlRol77fuzSqIfhLWdAjUO/ZrIXIL7enpl+khjAb8v+WyYB6/cHFZ2rfx4Rh8eQNjU4kBsnjJmkNGo6Q+7uF4TbQJZNQtHc5Vh9AXA5fh1AnvLr+UasTb0xQ4HKDO+uz+eRfAVD8eDA;20:0SK86XGljXLVu8TjhjQp/VJHKSNZBzNIKYWwqc8EbyARLKhgYd9SNeb3vmygLOcW83/XfrCHJacWO9r4BKyliK7P4DWskR1etxVUaxibZxXPp0/XLQLMNMPDcj1CODG+YXMl/3wXErzKfbCoXiMDWuLdDGdsEjwlCdMAQ4vOnxg= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020);SRVR:BYAPR05MB4325; x-ms-traffictypediagnostic: BYAPR05MB4325: authentication-results: spf=none (sender IP is ) smtp.mailfrom=namit@vmware.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231254)(944501410)(52105095)(93006095)(93001095)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016);SRVR:BYAPR05MB4325;BCL:0;PCL:0;RULEID:;SRVR:BYAPR05MB4325; x-forefront-prvs: 07013D7479 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(39380400002)(376002)(346002)(366004)(396003)(189003)(199004)(6512007)(76176011)(102836004)(4326008)(305945005)(36756003)(99286004)(5660300001)(478600001)(3280700002)(3660700001)(6506007)(6916009)(6246003)(446003)(3846002)(26005)(2906002)(14454004)(11346002)(2616005)(86362001)(186003)(476003)(486006)(105586002)(106356001)(6116002)(81166006)(54906003)(97736004)(82746002)(68736007)(81156014)(8676002)(83716003)(6436002)(53936002)(66066001)(33656002)(7736002)(25786009)(229853002)(6486002)(316002)(8936002)(2900100001)(5250100002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR05MB4325;H:BYAPR05MB4776.namprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: vmware.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: gof99B1zvJeIxwadZ6oj1X/Nm0Ryzl02otqHdaTy3Jiq4lS1qo9KO4UUVLMa6ayaOuMs21mdF+dJ1/DSuYkWKIIFxMQItgMd0znvKfjsC4ZiQQ0psecfwby2L3PffCY8EZrFHUwEuYHcnNdRoUH8ELbe4DAKyqUrgkJFfBWk5ftOHOQoJdWR9r/+yAdUYCK7 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <4E965DBDB900FA40B0FE71DB2D532381@namprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9a505098-f2dd-4126-20c2-08d5d017853b X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a505098-f2dd-4126-20c2-08d5d017853b X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2018 03:49:37.1331 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB4325 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org at 12:45 AM, Peter Zijlstra wrote: > On Sun, Jun 10, 2018 at 07:19:08AM -0700, Nadav Amit wrote: >> +/* >> + * This generates an indirect call based on the operation type number. >> + * The type number, computed in PARAVIRT_PATCH, is derived from the >> + * offset into the paravirt_patch_template structure, and can therefore= be >> + * freely converted back into a structure offset. >> + */ >> +.macro PARAVIRT_ALT type:req clobber:req pv_opptr:req >=20 > Unlike the marcro maze you replaced, this has the CALL hardcoded in. So > maybe name this PARAVIRT_CALL instead of PARAVIRT_ALT ? Sure. I will also merge the C macros of _paravirt_alt with paravirt_alt and remove the former.