Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Zhouyang Jia <jiazhouyang09@gmail.com>
Cc:     Zhouyang Jia <jiazhouyang09@gmail.com>,
        Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH] gfs2: add error handling for kmem_cache_zalloc
Date:   Tue, 12 Jun 2018 11:38:12 +0800
Message-Id: <1528774692-38990-1-git-send-email-jiazhouyang09@gmail.com>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

When kmem_cache_zalloc fails, the lack of error-handling code may
cause unexpected results.

This patch adds error-handling code after calling kmem_cache_zalloc.

Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
---
 fs/gfs2/trans.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c
index 064c9a0..da81eb4 100644
--- a/fs/gfs2/trans.c
+++ b/fs/gfs2/trans.c
@@ -130,6 +130,9 @@ static struct gfs2_bufdata *gfs2_alloc_bufdata(struct gfs2_glock *gl,
 	struct gfs2_bufdata *bd;
 
 	bd = kmem_cache_zalloc(gfs2_bufdata_cachep, GFP_NOFS | __GFP_NOFAIL);
+	if (!bd)
+		return NULL;
+
 	bd->bd_bh = bh;
 	bd->bd_gl = gl;
 	bd->bd_ops = lops;
-- 
2.7.4