Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] net: add error handling for kmem_cache_create
To:     Zhouyang Jia <jiazhouyang09@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Wei Wang <weiwan@google.com>, Martin KaFai Lau <kafai@fb.com>,
        Kees Cook <keescook@chromium.org>,
        Eric Dumazet <edumazet@google.com>,
        Florian Westphal <fw@strlen.de>, Joe Perches <joe@perches.com>,
        linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1528777798-40722-1-git-send-email-jiazhouyang09@gmail.com>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <17050ede-26b7-dfa5-91c5-e94da3e336e6@gmail.com>
Date:   Mon, 11 Jun 2018 21:31:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1528777798-40722-1-git-send-email-jiazhouyang09@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 06/11/2018 09:29 PM, Zhouyang Jia wrote:
> When kmem_cache_create fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling kmem_cache_create.
> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
>  net/decnet/dn_route.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
> index e747650..2b743c7 100644
> --- a/net/decnet/dn_route.c
> +++ b/net/decnet/dn_route.c
> @@ -1861,6 +1861,9 @@ void __init dn_route_init(void)
>  	dn_dst_ops.kmem_cachep =
>  		kmem_cache_create("dn_dst_cache", sizeof(struct dn_route), 0,
>  				  SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
> +	if (!dn_dst_ops.kmem_cachep)
> +		panic("Failed to create dn_dst_cache cache\n");
> +

Not needed, since SLAB_PANIC would have paniced the box earlier.

>  	dst_entries_init(&dn_dst_ops);
>  	timer_setup(&dn_route_timer, dn_dst_check_expire, 0);
>  	dn_route_timer.expires = jiffies + decnet_dst_gc_interval * HZ;
>