Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Jun 2018 08:45:56 +0200
Message-ID: <s5hsh5szemz.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     "Zhouyang Jia" <jiazhouyang09@gmail.com>
Cc:     <alsa-devel@alsa-project.org>,
        "Bhumika Goyal" <bhumirks@gmail.com>,
        "Jaroslav Kysela" <perex@perex.cz>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: lx6464es: add error handling for pci_ioremap_bar
In-Reply-To: <1528773796-37922-1-git-send-email-jiazhouyang09@gmail.com>
References: <1528773796-37922-1-git-send-email-jiazhouyang09@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 12 Jun 2018 05:23:14 +0200,
Zhouyang Jia wrote:
> 
> When pci_ioremap_bar fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling pci_ioremap_bar.
> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>

This patch makes no sense, sorry.  The whole lx6464es error handling
there is buggy.  We need to fix it more properly.

And, you must have noticed a bad smell in that change before
submitting this.  Basically, using the same goto label for the error
handling of the next step is already fishy.  In this case, you'd have
to unmap at the error path after this point.  If you can use the same
label, it means that the unmap is missing -- already something wrong.


thanks,

Takashi

> ---
>  sound/pci/lx6464es/lx6464es.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/pci/lx6464es/lx6464es.c b/sound/pci/lx6464es/lx6464es.c
> index 9655b08..6157b6d 100644
> --- a/sound/pci/lx6464es/lx6464es.c
> +++ b/sound/pci/lx6464es/lx6464es.c
> @@ -1016,6 +1016,10 @@ static int snd_lx6464es_create(struct snd_card *card,
>  
>  	/* dsp port */
>  	chip->port_dsp_bar = pci_ioremap_bar(pci, 2);
> +	if (!chip->port_dsp_bar) {
> +		dev_err(card->dev, "cannot remap PCI memory region\n");
> +		goto request_irq_failed;
> +	}
>  
>  	err = request_threaded_irq(pci->irq, lx_interrupt, lx_threaded_irq,
>  				   IRQF_SHARED, KBUILD_MODNAME, chip);
> -- 
> 2.7.4
> 
>