Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=gb2312
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
Subject: Re: [PATCH] gfs2: add error handling for kmem_cache_zalloc
From:   "cgxu519@gmx.com" <cgxu519@gmx.com>
In-Reply-To: <1528774692-38990-1-git-send-email-jiazhouyang09@gmail.com>
Date:   Tue, 12 Jun 2018 15:24:41 +0800
Cc:     "cgxu519@gmx.com" <cgxu519@gmx.com>,
        Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <C20C8754-0C63-4EB2-B3E9-68E4EE29338D@gmx.com>
References: <1528774692-38990-1-git-send-email-jiazhouyang09@gmail.com>
To:     Zhouyang Jia <jiazhouyang09@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> ?? 2018??6??12?գ?????11:38??Zhouyang Jia <jiazhouyang09@gmail.com> д????
> 
> When kmem_cache_zalloc fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling kmem_cache_zalloc.

Should not fail on this case.

Thanks,
Chengguang.


> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
> fs/gfs2/trans.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/fs/gfs2/trans.c b/fs/gfs2/trans.c
> index 064c9a0..da81eb4 100644
> --- a/fs/gfs2/trans.c
> +++ b/fs/gfs2/trans.c
> @@ -130,6 +130,9 @@ static struct gfs2_bufdata *gfs2_alloc_bufdata(struct gfs2_glock *gl,
> 	struct gfs2_bufdata *bd;
> 
> 	bd = kmem_cache_zalloc(gfs2_bufdata_cachep, GFP_NOFS | __GFP_NOFAIL);
> +	if (!bd)
> +		return NULL;
> +
> 	bd->bd_bh = bh;
> 	bd->bd_gl = gl;
> 	bd->bd_ops = lops;
> -- 
> 2.7.4
>