Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=gb2312
Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\))
Subject: Re: [PATCH] inotify: add error handling for kmem_cache_create
From:   "cgxu519@gmx.com" <cgxu519@gmx.com>
In-Reply-To: <1528777362-40212-1-git-send-email-jiazhouyang09@gmail.com>
Date:   Tue, 12 Jun 2018 15:41:54 +0800
Cc:     "cgxu519@gmx.com" <cgxu519@gmx.com>, Jan Kara <jack@suse.cz>,
        Amir Goldstein <amir73il@gmail.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8BIT
Message-Id: <5381809C-13EE-42BC-883B-F8E5A90FD1C5@gmx.com>
References: <1528777362-40212-1-git-send-email-jiazhouyang09@gmail.com>
To:     Zhouyang Jia <jiazhouyang09@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> ?? 2018??6??12?գ?????12:22??Zhouyang Jia <jiazhouyang09@gmail.com> д????
> 
> When kmem_cache_create fails, the lack of error-handling code may
> cause unexpected results.
> 
> This patch adds error-handling code after calling kmem_cache_create.

I think SLAB_PANIC can handle this case.

Thanks,
Chengguang.

> 
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
> fs/notify/inotify/inotify_user.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
> index ef32f36..0704bab 100644
> --- a/fs/notify/inotify/inotify_user.c
> +++ b/fs/notify/inotify/inotify_user.c
> @@ -805,6 +805,8 @@ static int __init inotify_user_setup(void)
> 	BUG_ON(hweight32(ALL_INOTIFY_BITS) != 21);
> 
> 	inotify_inode_mark_cachep = KMEM_CACHE(inotify_inode_mark, SLAB_PANIC);
> +	if (!inotify_inode_mark_cachep)
> +		return -ENOMEM;
> 
> 	inotify_max_queued_events = 16384;
> 	init_user_ns.ucount_max[UCOUNT_INOTIFY_INSTANCES] = 128;
> -- 
> 2.7.4
>