Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5015666imm; Tue, 12 Jun 2018 00:49:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJIrwqLxboXhAzL7gFymac8lfx71parGAQVAA8w5QOJZKyhikbUhdE6fhw/GnmUOuyWdLYJ X-Received: by 2002:a62:9419:: with SMTP id m25-v6mr2700046pfe.120.1528789756280; Tue, 12 Jun 2018 00:49:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528789756; cv=none; d=google.com; s=arc-20160816; b=ez7S3XwWXX4bCAaajiUYNS2BRTdWko9YnfKv1Umva1ZqEfhZn51tFLBTld4pxVL9ep dvC2yzD1zCQUiNSJmudbDGrMlw4BaeyJlWtpMkaFBexGgbibh3Fe9hHo5XmCi+R9ftPf LXmksh4OTgomoYwKG5N/daqS9G+jd0sNHzhZ717CYdJNntzF5qRw5FCZcjGEXl4nvNN7 VLuEYNqbrvobxfaDfSGGwPdrALlLIWVEoabHfmHIZljZsSpBE5hGIQL4Xh58BxHUpxBI 18JVcT86meVlLtJGm8R7KOxGGX/9AtKiZ1HMZq8zYv0KLBMpqMvWfLhOY21WspziMO31 W5zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=cBP/KqsxHGyaFOG+qbGwqHMpDu3pZ5DW+CXpb7iuNhk=; b=bnCTjr+SnuZoJicmjwf5aphdL9ZjhxN6Pqh3uule8jy2p5/Bug0iRgH4xHRFXms9rH Ju8qC7pbhFsXPd8PK/Ha9lUwV4PeqF0Du0phvILBgJk2+bT3aUdCD6WOuex04mtLwhwU NPX6hmzyGL1h6EgDKlhVOXHqJgcj9WyFMFbOU3mYSgc8nSii8NCT8qJFkecqSWbEVif2 J/Fz50+4sINXUUVOkDgGUreY6H+4sFZQJXI0sUUfDHILc8gyznmYIIR7srPrBlcHauRc nDd1AGr4lk7OjTTthp3YRAMAWIzOJa6cL8eEC7XwN/fi1iSL8C5ohFnhYaMeOb08UIej jU/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=g8CQiZRP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8-v6si221292pgq.637.2018.06.12.00.49.02; Tue, 12 Jun 2018 00:49:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=g8CQiZRP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933421AbeFLHsd (ORCPT + 99 others); Tue, 12 Jun 2018 03:48:33 -0400 Received: from smtprelay.synopsys.com ([198.182.37.59]:39209 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933244AbeFLHsc (ORCPT ); Tue, 12 Jun 2018 03:48:32 -0400 Received: from mailhost.synopsys.com (mailhost2.synopsys.com [10.13.184.66]) by smtprelay.synopsys.com (Postfix) with ESMTP id 71BC31E04A3; Tue, 12 Jun 2018 09:48:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1528789710; bh=4h3IQ4zqWg9nkcRzeMskTCRxGrJ8+me7ZCSUyvkOch0=; h=From:To:CC:Subject:Date:References:From; b=g8CQiZRPITqwg75IZq4YowaIEdPJft508nJWxvP9sqS56yTqFo0pDG+vr/w0y289Z M+sJiJlm/yxTT92uE3Plj7ToAqi9p7D8zjN3x2opqG1sk21BCspkXF+ELEkImJ2BVm Ca8RP55BP7ZGFKir8ziG7kyI4vbktr8b6DvufTJ3Vn5op3Asp6OKKgEbF/QSR6yJMA 00mDy0Sk9KN+pas0SEIqAfIkLY/yeTl5NyAwU5aQIpTunl5EWOvo5RnfOiRKOTKVFh 5X2QuIAHFsWpI867lIuMiAfjG8KQVqUxkNY1MElXHGc/7fpt5Fc+ZU5tCUhAalSD0T 00OYiknplA/Iw== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1.internal.synopsys.com [10.12.239.235]) by mailhost.synopsys.com (Postfix) with ESMTP id C5D683203; Tue, 12 Jun 2018 00:48:29 -0700 (PDT) Received: from AM04WEHTCA.internal.synopsys.com (10.116.16.190) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.361.1; Tue, 12 Jun 2018 00:48:29 -0700 Received: from AM04WEMBXA.internal.synopsys.com ([fe80::79c3:55f2:1f20:5bf4]) by am04wehtca.internal.synopsys.com ([::1]) with mapi id 14.03.0361.001; Tue, 12 Jun 2018 11:48:27 +0400 From: Minas Harutyunyan To: Zeng Tao , "Minas.Harutyunyan@synopsys.com" CC: Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak Thread-Topic: [PATCH] usb: dwc2: gadget: fix packet drop issue in dwc2_gadget_handle_nak Thread-Index: AQHUAhnEFlH/rSKsX0G4MTSftUwoTw== Date: Tue, 12 Jun 2018 07:48:25 +0000 Message-ID: <410670D7E743164D87FA6160E7907A56013A5AA95B@am04wembxa.internal.synopsys.com> References: <1528814947-27098-1-git-send-email-prime.zeng@hisilicon.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.116.70.165] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Acked-by: Minas Harutyunyan =0A= =0A= On 6/12/2018 10:51 AM, Zeng Tao wrote:=0A= > In ISOC transfer, when the NAK interrupt happens, we shouldn't complete= =0A= > a usb request, the current flow will complete one usb request with no=0A= > hardware transfer, this will lead to a packet drop on the usb bus.=0A= > =0A= > Signed-off-by: Zeng Tao =0A= > ---=0A= > drivers/usb/dwc2/gadget.c | 3 ---=0A= > 1 file changed, 3 deletions(-)=0A= > =0A= > diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c=0A= > index f0d9ccf..fbe65f6 100644=0A= > --- a/drivers/usb/dwc2/gadget.c=0A= > +++ b/drivers/usb/dwc2/gadget.c=0A= > @@ -2817,9 +2817,6 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsot= g_ep *hs_ep)=0A= > =0A= > tmp =3D dwc2_hsotg_read_frameno(hsotg);=0A= > if (using_desc_dma(hsotg)) {=0A= > - dwc2_hsotg_complete_request(hsotg, hs_ep,=0A= > - get_ep_head(hs_ep), 0);=0A= > -=0A= > hs_ep->target_frame =3D tmp;=0A= > dwc2_gadget_incr_frame_num(hs_ep);=0A= > dwc2_gadget_start_isoc_ddma(hs_ep);=0A= > =0A= =0A=