Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <C20C8754-0C63-4EB2-B3E9-68E4EE29338D@gmx.com>
References: <1528774692-38990-1-git-send-email-jiazhouyang09@gmail.com> <C20C8754-0C63-4EB2-B3E9-68E4EE29338D@gmx.com>
From:   Andreas Gruenbacher <agruenba@redhat.com>
Date:   Tue, 12 Jun 2018 10:23:30 +0200
Message-ID: <CAHc6FU6M0dOnJOuJ9ffP22Qbd0tkQ3mPqt7BexjeJ4rPPJdz8w@mail.gmail.com>
Subject: Re: [PATCH] gfs2: add error handling for kmem_cache_zalloc
To:     "cgxu519@gmx.com" <cgxu519@gmx.com>
Cc:     Zhouyang Jia <jiazhouyang09@gmail.com>,
        Bob Peterson <rpeterso@redhat.com>,
        cluster-devel <cluster-devel@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12 June 2018 at 09:24, cgxu519@gmx.com <cgxu519@gmx.com> wrote:
>
>> 在 2018年6月12日，上午11:38，Zhouyang Jia <jiazhouyang09@gmail.com> 写道：
>>
>> When kmem_cache_zalloc fails, the lack of error-handling code may
>> cause unexpected results.
>>
>> This patch adds error-handling code after calling kmem_cache_zalloc.
>
> Should not fail on this case.

Indeed, with the __GFP_NOFAIL flag, kmem_cache_zalloc will not fail.
This is documented in include/linux/gfp.h.

Thanks,
Andreas