Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5053300imm;
        Tue, 12 Jun 2018 01:33:18 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKIcmljCye1qCRjJqSLhvB0OaMJ7yTybZEt4sW/fZywb5XNMHMasBPCr4qc3f9hO4OalzaC/
X-Received: by 2002:a17:902:74cc:: with SMTP id f12-v6mr3020990plt.7.1528792398928;
        Tue, 12 Jun 2018 01:33:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1528792398; cv=none;
        d=google.com; s=arc-20160816;
        b=wPRYT8XzG0pZJZn6wWCb4fG6+O0bcYVNpsUlmcH8dTR7GF1bCy2s2Cqaoe9jhFeSzq
         6Nr+dEQNfZnfda2Fk1AdxTU+pB6m8ybcu+JieNriZsojMo+jKNBeCMMiXQxrwGCp+m43
         Uy1KQUA7k6g2UYls/XmoRrB0Ub9f76TVaLxdCCOkZET9ngFJLqG/0aqRtDUOXXVTFpO6
         KlkWoTk2Ze3sITW95jEp1eYVD7zTf0ivxf5QS9wRZmYz5XT1f6IpJnxdSqWrk42rPFBK
         FRZeS41qQy5/YIOuJCUatKtITkiikFGMM2dawlkT+22jGmr27OiU2fJPM0pDIDuwrRou
         55TQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :references:in-reply-to:mime-version:dkim-signature
         :arc-authentication-results;
        bh=N4/sjuyG/dN16xcacAyqwodTkKRTajg9K6qM/h9WW34=;
        b=UR/KyjLJ4R8scc1eHtcr19B2E9ETGo3PeXLA6z2+3dHQSCwAEkAB7VG5CgyvHSrGUZ
         uJ1yyqUAAIxbv3+vbiF1KChNM4/bNbM5ysNpM2oEgS20SNHWF20yebELT5/Grmys+/OM
         Mm13ONEvAcSx0hay10aSTUhJX3jHnUj7auw/wAx9ap36VvBk8rU/Oqr3aOYT4nQsNZ3Q
         ZU87wpbbOdA2Qm0lLt63/QE8vJqYPJsi9zCWsgILS3lbjQTMd9seZ0WEK7ZD/j/eTFcV
         1fsWbIbj2TLPbAybqrfMjlV/IhdzGw4AbY07czNDSR/VZuSTbQvLUpNPLxJbL7YlQhjf
         Bj5Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=qttvzrli;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id f4-v6si275925pgq.123.2018.06.12.01.33.04;
        Tue, 12 Jun 2018 01:33:18 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@gmail.com header.s=20161025 header.b=qttvzrli;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933928AbeFLIcQ (ORCPT <rfc822;fygvjjghggcfgvhhgsgrguf@gmail.com>
        + 99 others); Tue, 12 Jun 2018 04:32:16 -0400
Received: from mail-ua0-f196.google.com ([209.85.217.196]:36940 "EHLO
        mail-ua0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933367AbeFLIcO (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Jun 2018 04:32:14 -0400
Received: by mail-ua0-f196.google.com with SMTP id i3-v6so15392165uad.4;
        Tue, 12 Jun 2018 01:32:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20161025;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=N4/sjuyG/dN16xcacAyqwodTkKRTajg9K6qM/h9WW34=;
        b=qttvzrliFiAWqoVZnLxa537Etjh6KmxSnEc4tSHx0G2dRsQVVobmo1z97z58wpvfY8
         Oi5hySz8LQxDjuVZRZtYTBwbeC8tfxNB76YpSEaqOdqbbcxQU5Hp3HFYPjHV5B6Rw+jb
         94uJFcpKJVdZ/KUg8lxkIPU5GS4msEjoLhY0BhdltWO06XjMXptGmSvwh4C6tfyO2wAd
         5OP749UsXJeGoehP1tfuyNHut7+u4ZvAoUhcgM6CAvreRv9HGeeJJh/w/zFzHCcIXaj6
         p8VriASUXr0trGghjseAV71r2Jng4aA8gYZj7EVhxwF+wZ2n53DOTgjwKmjkDm3bhf7D
         k1Lw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=N4/sjuyG/dN16xcacAyqwodTkKRTajg9K6qM/h9WW34=;
        b=LbGIl7PvLhcjSn4A6AJm4czOxxHsnS0PCSGvlmgDm4MkGRBD3Q1CzwoflgLOrAnvhh
         h7m9oYn3HsSIgDkecR3MLjeNSHQln0FFUrjEfvmXJLub5NSmzk+WkzIwMJTdnTfWk7a6
         2F6C+UiGxsD7AAn4/P+ba6wpw2P6XHZCv2xPv9NTRRyW4Wa79woQPs4pTxDCzr0BjsXv
         RVH+o+AZuyRnQ+AF7KUtiZ2LpLf9mhJRMMwIPbBv8L5wxP0vFgsQ3SbXYktMz9J9XmBf
         Ohcf4NT0zjr8oxAgL4swTUC5nJLktUhiezsEsf1cCSv2zmqopo+FXsRI0qPVJAxYAymN
         d7BA==
X-Gm-Message-State: APt69E0KEKfSuJvSEjzcLzea/tZ09xJAt8i6WGm1mMgRI2f0aWIUZqae
        5Ry0soDZIgO6+aKU+ZhFedoTmLv7/3GQV2Pmtpc=
X-Received: by 2002:a9f:3613:: with SMTP id r19-v6mr1779775uad.49.1528792333580;
 Tue, 12 Jun 2018 01:32:13 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a67:8b02:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 01:32:13
 -0700 (PDT)
In-Reply-To: <1528774132-38287-1-git-send-email-jiazhouyang09@gmail.com>
References: <1528774132-38287-1-git-send-email-jiazhouyang09@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 12 Jun 2018 11:32:13 +0300
Message-ID: <CAHp75Vet9dzrJE0nzTe2HRy50UCsaSyNJueiFVrNfgtr4wmhzQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: max732x: add error handling for i2c_new_dummy
To:     Zhouyang Jia <jiazhouyang09@gmail.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 12, 2018 at 6:28 AM, Zhouyang Jia <jiazhouyang09@gmail.com> wrote:
> When i2c_new_dummy fails, the lack of error-handling code may
> cause unexpected results.

What results?
Where is the analisys?

Would driver work w/o these dummy devices?

-- 
With Best Regards,
Andy Shevchenko