Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5230558imm; Tue, 12 Jun 2018 04:52:09 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL+ehh4p0ewH0YcaDnY6N/8QTJOHKlmXAAzO9z+pYiTaWhAucDzXhqNIxC0f2964HcRByOS X-Received: by 2002:a17:902:82cc:: with SMTP id u12-v6mr34502plz.83.1528804329593; Tue, 12 Jun 2018 04:52:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528804329; cv=none; d=google.com; s=arc-20160816; b=ZtEw4Vl9TZb7WvOSDqkeQfNUmF8fZ82AQ7tfAlmC/VY1rV35/TIO/fcwfWNXtpx5nP gM9O/H9TfOqbtHwR+okF3t22EuQM1OhUT1860nLEqdAjtUFYrlnoGB2WNb0NOoZmifCC l+o1dnWgnoQfn2S7EN1rY1JK+G/3bCSGwRgn377NcLFSWUqargtQ2gKBNyuyM1XgidF5 QYf3QgynNI6wt7y/MY8OvM/HlcUxngBCbJMsUH4L6N8kXfzv7i8b3F5l8sZ+YtTFvq8I QuJKbhkocbNPb0oQ0/sxjFNM/jQsl/jFn8pQvYeqygfIci6lsNLeDNAI4iyhjmlWLuAg Xgtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Eiz6F8v714qmX2pfN+Bqzjkuvp8aD5p4rZwLTdVKEMI=; b=mV4k8NU2abN9eIXPw2Ryl35IDea7t4J2/l4EhoQBY0WGskhTUsinW2PzT2VdhWDWxn RpcDAnpzjNX0CIkjRKRVky0E10it4BlOVz4iK1qDsZU/VmOv+gTwLcFP/qUqlZ/xGj/K rPj3OyMY52TN6Bc7CXSvXkessPqHsGGcLhbhOEZEZWukysm5qctp1/W4gKWChcwzqVIp fIt0SS0rTjMQxUTDgps6pHl1ErhudgLnijdFY+fKXMwxwAmmfgPJY+Ix9TrdPmxc0FHX BTWMmBC7dJZT5tGXZvNyMbFRCy6E13H6uIzizYIM0amAS/T/nJ5NMpImzYFW450fGrAx rRUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=HSxnFF7N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c18-v6si757037plo.185.2018.06.12.04.51.55; Tue, 12 Jun 2018 04:52:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2017-10-26 header.b=HSxnFF7N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933513AbeFLLu5 (ORCPT + 99 others); Tue, 12 Jun 2018 07:50:57 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:53576 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754299AbeFLLu4 (ORCPT ); Tue, 12 Jun 2018 07:50:56 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5CBkAL9132801; Tue, 12 Jun 2018 11:50:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2017-10-26; bh=Eiz6F8v714qmX2pfN+Bqzjkuvp8aD5p4rZwLTdVKEMI=; b=HSxnFF7NcjQEO4WlxqTT3A3FfSzJ83iesjSRJLp1tu/C4rVsUnIAvuxzgN7VyOTWBceA kJazDJPGewyK4J2DjZKN7F6CG/uzYoPFgNTnOQbeez8t+lkoE69tY92nVIWmQnxz+knk yeafFs+ydjEGv/Xcd9RkT3H5xzL5ToEMRS7pIc0X7E7+65P1/cmaK7j56/RHVDRLlVs/ rYG1CSZdNYXVi+BRJ6KDg/Pg7/GWCZuvxP0AlpMZXB5Fj2UrARupWgqoSxfc9TFekkwt WMFJWbSaWRApQL/J8eJfggr1ipXaT3osItYoVY9NOUAcmwCfGxZCpeDQIa1BP0R5/XJq yg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2jg4dm1u53-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jun 2018 11:50:49 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w5CBom4K011712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jun 2018 11:50:49 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w5CBomcL026814; Tue, 12 Jun 2018 11:50:48 GMT Received: from mwanda (/197.157.0.30) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 12 Jun 2018 04:50:47 -0700 Date: Tue, 12 Jun 2018 14:50:39 +0300 From: Dan Carpenter To: Zhouyang Jia Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Ian Abbott Subject: Re: [PATCH] staging: comedi: add error handling for vmap Message-ID: <20180612115039.sz4zjgf7vrudpvyx@mwanda> References: <1528773937-38106-1-git-send-email-jiazhouyang09@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528773937-38106-1-git-send-email-jiazhouyang09@gmail.com> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8921 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=671 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806120137 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 12, 2018 at 11:25:35AM +0800, Zhouyang Jia wrote: > When vmap fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling vmap. > Again, this is not error handling, this is just an error message. This error condition is handled in the caller. regards, dan carpenter