Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5588494imm; Tue, 12 Jun 2018 10:02:54 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJVjHX2wSoCO25BKFvhGMyTwUhkBRKQSdKXsSHUAAoUkltwjE1OXVHFS2IYAe+rJgY+/Rf2 X-Received: by 2002:a17:902:6b09:: with SMTP id o9-v6mr1279796plk.256.1528822974688; Tue, 12 Jun 2018 10:02:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528822974; cv=none; d=google.com; s=arc-20160816; b=rRijtjGRWWDVcRtFw5LsdbSFtoWB0OIQoyxamiLuW436TtKKJNkjl13/TRBSNMQCQe ZxB/Lw2CM3xrFwAzCZuvvLqPXz6eLC6CS1UNGBHSlwVZvo/fDwygogAj+yIH48bXTugw jICxidLMYdrcd+oxwsVR3ORwt9lkhx/uN/mJZJoij9M/J5YrP2KkmuevLdb5BCrWQeuG DEYJUeU4HlgBIrxiu6e9qSd0qN6dtcp2pLfDIg0dMaPtfHTrZuwIHL13tdmXdsPqmlJp uPmvHfGC1Dlg2QRlvfDyKF+4v1uIVBaRbCs7B867I8vu4ozrTVLO6mcxKuQD1VMyp4ju sIvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=aVFopFnF0PxVWntXLCX92HnLVaK/i1SQ+de/P8qWQtY=; b=d9HNZOx8/Vd55NYDuCaFVxKkiW7RESgEZkS0kbm9ITucO5YmEDd9iW90pgpf5vXA35 YDUpQZ44bETiPwMstu8/RUeAGjEGCd2Ge6ZX6P7lu9T3yKW5WGNJmK31w5O1lRMOBkWZ sd8YFedDA9454O6lfj2Fsyh+zVFEI3kBehAgEWiUdXKqYVcnxHZkvvxjOgDq+SWAb9Kz oREKe7+I/wQG0pNQkN9PLK5VHsKHw+GeDxMn2CSVNiIh7rT66XA+Hl5QhqED7VMLlfGy JfRkWoRqpnlNITpGGHBH8d3PzlpeHCxs9rIc+Q/4Jwq6gNVDud/9rhB2xhnnYAE55nqm BRgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=asrL56Kw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r59-v6si487260plb.314.2018.06.12.10.02.39; Tue, 12 Jun 2018 10:02:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=asrL56Kw; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935055AbeFLQxP (ORCPT + 99 others); Tue, 12 Jun 2018 12:53:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:50918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754343AbeFLQxI (ORCPT ); Tue, 12 Jun 2018 12:53:08 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35967208BA; Tue, 12 Jun 2018 16:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528822388; bh=ka5Ym23zn3/4xWhph80MyzDON/TUTgyRgTmHX9+WiAw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=asrL56KwYB4SfXDHdJMp3mDVfvYEG+3TH1UX7/AJLFcPzpe4bieukK4onNl8hUXSW Gdghl2ueTdajeXLZ6akB1vm83EFdH+W6x0gfXeeuuQuquxmDmPbiODPD6MK2DzlUIV a188mazk+2RRuuSqjiy9Die3Cjbk621V0q2vnGnA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shahed Shaikh , Ariel Elior , "David S. Miller" Subject: [PATCH 4.4 19/24] qed: Fix mask for physical address in ILT entry Date: Tue, 12 Jun 2018 18:52:03 +0200 Message-Id: <20180612164817.625996766@linuxfoundation.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180612164816.587001852@linuxfoundation.org> References: <20180612164816.587001852@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Shahed Shaikh [ Upstream commit fdd13dd350dda1826579eb5c333d76b14513b812 ] ILT entry requires 12 bit right shifted physical address. Existing mask for ILT entry of physical address i.e. ILT_ENTRY_PHY_ADDR_MASK is not sufficient to handle 64bit address because upper 8 bits of 64 bit address were getting masked which resulted in completer abort error on PCIe bus due to invalid address. Fix that mask to handle 64bit physical address. Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support") Signed-off-by: Shahed Shaikh Signed-off-by: Ariel Elior Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qed/qed_cxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/qlogic/qed/qed_cxt.c +++ b/drivers/net/ethernet/qlogic/qed/qed_cxt.c @@ -43,7 +43,7 @@ #define ILT_CFG_REG(cli, reg) PSWRQ2_REG_ ## cli ## _ ## reg ## _RT_OFFSET /* ILT entry structure */ -#define ILT_ENTRY_PHY_ADDR_MASK 0x000FFFFFFFFFFFULL +#define ILT_ENTRY_PHY_ADDR_MASK (~0ULL >> 12) #define ILT_ENTRY_PHY_ADDR_SHIFT 0 #define ILT_ENTRY_VALID_MASK 0x1ULL #define ILT_ENTRY_VALID_SHIFT 52