Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <1528432379-9605-1-git-send-email-jananis37@gmail.com>
References: <1528432379-9605-1-git-send-email-jananis37@gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 12 Jun 2018 20:01:54 +0300
Message-ID: <CAHp75VfKBkZ3znZn4YQPyOCrzT8aKZ0OAFTP2uErhoEgD13Z+A@mail.gmail.com>
Subject: Re: [PATCH 1/4] Staging:rtl8192e Replace function names by using
 __func__ identifier
To:     Janani Sankara Babu <jananis37@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johannes Berg <johannes.berg@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Kees Cook <keescook@chromium.org>, Rene.Hickersberger@gmx.at,
        devel@driverdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 8, 2018 at 7:32 AM, Janani Sankara Babu <jananis37@gmail.com> wrote:
> This patch is created to solve the warning shown by checkpatch script
> Prefer using '"%s...", __func__' to using ', this function's name,
> in a string

Have you even tried to compile it?

NAK

>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index c466a5e7..3c7ba33 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -127,7 +127,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device *ieee, u8 *Dst,
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_ADDBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         return skb;
> @@ -178,7 +178,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_device *ieee, u8 *dst,
>         tag += 2;
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         return skb;
> @@ -243,7 +243,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_rx_ADDBAReq(): ", DUMP_PREFIX_NONE,
> +       print_hex_dump_bytes("%s(): ", __func__, DUMP_PREFIX_NONE,
>                              skb->data, skb->len);
>  #endif
>
> @@ -441,7 +441,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
>         }
>
>  #ifdef VERBOSE_DEBUG
> -       print_hex_dump_bytes("rtllib_rx_DELBA(): ", DUMP_PREFIX_NONE, skb->data,
> +       print_hex_dump_bytes("%s():", __func__, DUMP_PREFIX_NONE, skb->data,
>                              skb->len);
>  #endif
>         delba = (struct rtllib_hdr_3addr *)skb->data;
> --
> 1.9.1
>


-- 
With Best Regards,
Andy Shevchenko