Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5595810imm; Tue, 12 Jun 2018 10:08:39 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIUw6vMFiEH6QXdkYUDjzRMF3qcRTIrRsg7bgdBTVZ2AJmR/ZERh5r0MiKAxhwmw6CkXZed X-Received: by 2002:a63:8048:: with SMTP id j69-v6mr1024302pgd.429.1528823319573; Tue, 12 Jun 2018 10:08:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528823319; cv=none; d=google.com; s=arc-20160816; b=MZfHAP+d+3eg2rXcudzAzRErAX4ymebP5uptBCvM7xAAb8/MBltivP6T2wPhsAaHge Iaouu7+eFeyRnVGio8a7Q4h5dgniUWPKSVZYtSoRXwTT3TqJg5LaOqZNUxTz4yRUjtH/ /iTRgXZTRgG2cRpmwyoMTuoNzzjV9b11vnNFOu5PpffahCZUSJpg/pmVbUcCQTMs7veE Q+LtDCwAcCOyAmtyopll1GVs1LhL6h0mDCmafvMj8a2BjqWKe3M/mbkqBmDfNr6yQJBQ TIg6RwNPqiRdLkCzqZ4fljASUrsjADphLlf5D1Oth0LKL+pM2ph0os1RE3Pr7xORsUjx xrRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=LBlOOu7V2vdaXnytjqweoEtAJ5H9yjuxRDefypomlxQ=; b=c8ETwsUytDtjdc+vxxjlazTfkXzlXiSoQ+UBL+4AU8ZbMzrHQnIFirmL/a71PYZsVb to7GTAjdfxVwzepTD4ncKCfKzyMclcDafASsbpxmHTEqodUwB3aJZifgMPKExYrMBR8e k8U3uBeUp/CCqyLOH37OoyK5Gie2LYoeGOve4wo1U4bKv9xSiC+28mlXBzWQ2356djYT NnMybaZQkhlo8cuAeOSfvO4JQjyCTRt5mZCylRtN666bV0CUtlt6sEMMcbLhYl8IRjxz CXIU/3RUqv733XH9yzaBWfPjhddmEBwWw7wdNQB2SUBnuxj8FL7XgBMJK/DBOWE6S4aH cSyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KOmAUjPv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y13-v6si550397pfc.302.2018.06.12.10.08.24; Tue, 12 Jun 2018 10:08:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KOmAUjPv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754323AbeFLRH4 (ORCPT + 99 others); Tue, 12 Jun 2018 13:07:56 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:38166 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754056AbeFLRHx (ORCPT ); Tue, 12 Jun 2018 13:07:53 -0400 Received: by mail-vk0-f65.google.com with SMTP id b77-v6so14826982vkb.5; Tue, 12 Jun 2018 10:07:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=LBlOOu7V2vdaXnytjqweoEtAJ5H9yjuxRDefypomlxQ=; b=KOmAUjPvIRZ3i3qapH43UBRlGe7Y5oZmhHeImCeGVhzfCK7LjoDZEw3csWsqpAPRz3 6BQLqTU7qcpgjdZCf82nqrIOG/Y87HTCYvcsim9vki0GTnsNwwC83MsJiJGDBuY8TQzq LWaBtxdOv8rXcHMOYJVndxxIbMRqo7RNkNEfqaLzBPufP9R0moSN/xfPvSaOT2tMx/fJ qFiSM26RBTp8aIPfnd/qd3WKdp9ffInGDJJsH7/wx5LJwM8zlU27S2S9NWIfGX83qdBd C7CcPEjFp3FWZngvSOpbZ7UK3yPWwrSSpb5Dj2DAVDism7JUItRzE9PTWdBwC1vW5PJz bOig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=LBlOOu7V2vdaXnytjqweoEtAJ5H9yjuxRDefypomlxQ=; b=EV03a1Efk+S/ZssjvOK3rkt/DxXHZUV9Vld8VKYOQUYj08b5bHREZo+g5FwIp3dYnv /oRypb9mL2NxDgSYW412WMGZ5c7mDjwFINJoL3nQWGEQh724buDBjDTbojvcC/XT7pNJ GSJanmIXs9ETsssOJzyO1j+dlW9DDuZYJBmx3gRZXvbTpOyBW1EY1AFDdTS/gQyc/Z4O RxeqUForvA4HJzphfTgU/udQfjnFj8scrzTRHLeEy8Pjpr/Oj7GPcpcLz4CJB+HPMcFx ZAIMMaPywEh3UQmDMnPcvV7AuQdPn6TjVqGkvW5eDoxO2shPbYTZlDsmeJKFflJzpEXb EpWQ== X-Gm-Message-State: APt69E38II7m5BRa/B6GPkRLRlGrekObPjPkOIDzX93ZoXpgIH6noamp zhU5AIEU4PXfTPASfaKg3ObRTrbc5jTngoh8e3r9RPE5 X-Received: by 2002:a1f:860b:: with SMTP id i11-v6mr834330vkd.15.1528823272623; Tue, 12 Jun 2018 10:07:52 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a67:8b02:0:0:0:0:0 with HTTP; Tue, 12 Jun 2018 10:07:52 -0700 (PDT) In-Reply-To: <1528310612-10158-1-git-send-email-clabbe@baylibre.com> References: <1528310612-10158-1-git-send-email-clabbe@baylibre.com> From: Andy Shevchenko Date: Tue, 12 Jun 2018 20:07:52 +0300 Message-ID: Subject: Re: [PATCH] mmc: dw_mmc should depend on COMMON_CLK To: Corentin Labbe , Geert Uytterhoeven Cc: Ulf Hansson , Linux Kernel Mailing List , linux-mmc@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +Cc: Geert On Wed, Jun 6, 2018 at 9:43 PM, Corentin Labbe wrote: > This patch fix the following build failure on m68k: > ERROR: "clk_set_rate" [drivers/mmc/host/dw_mmc.ko] undefined! > > Signed-off-by: Corentin Labbe > --- > drivers/mmc/host/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index 0581c199c996..77d6ba090436 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -666,7 +666,7 @@ config MMC_CAVIUM_THUNDERX > > config MMC_DW > tristate "Synopsys DesignWare Memory Card Interface" > - depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST > + depends on COMMON_CLK && (ARC || ARM || ARM64 || MIPS || COMPILE_TEST) > help > This selects support for the Synopsys DesignWare Mobile Storage IP > block, this provides host support for SD and MMC interfaces, in both > -- > 2.16.4 > -- With Best Regards, Andy Shevchenko