Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180608144834.3003465-1-arnd@arndb.de> <20180608181956.GA110395@decatoncale.mtv.corp.google.com>
 <20180611060819.GD5278@dell>
In-Reply-To: <20180611060819.GD5278@dell>
From:   Gwendal Grignou <gwendal@chromium.org>
Date:   Tue, 12 Jun 2018 12:53:51 -0700
Message-ID: <CAMHSBOU-f4oxR9kBkgYXOunRSUKx+cP3mJzmVKHnYJXfAzgHKQ@mail.gmail.com>
Subject: Re: [PATCH] mfd: cros_ec: remove unused __remove function
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Benson Leung <bleung@google.com>, Arnd Bergmann <arnd@arndb.de>,
        Gwendal Grignou <gwendal@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Benson Leung <bleung@chromium.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jun 10, 2018 at 11:08 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 08 Jun 2018, Benson Leung wrote:
>
> >
> > On Fri, Jun 08, 2018 at 04:48:06PM +0200, Arnd Bergmann wrote:
> > > This function is no longer called, so we get a harmless
> > > warning until it is removed as well:
> > >
> > > drivers/mfd/cros_ec_dev.c:265:13: error: '__remove' defined but not u=
sed [-Werror=3Dunused-function]
> > >
> > > Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data=
")
> >
> > Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/
> > you mentioned that you readded the __remove to avoid a warning when bui=
lt
> > as a module. Can you explain what's going on?
>
> Yes please, and quickly.  I'm going to sent the patch-set today.  If I
> don't hear from you promptly, I'll probably pull the patch!
I readded it because when cros_ec_dev is loaded as module, I get a
warning on dmesg when unloading:

"""Device 'cros_pd' [or 'cros_ec'] does not have a release() function,
it is broken and must be fixed."""

The warning comes from device_release(). Given I get a warning when I
remove the release function or when I leave it empty. Let's pull the
patch.

Sorry for the confusion,

Gwendal.
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog