Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp5800212imm; Tue, 12 Jun 2018 13:37:10 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLrdvWkZHqst8UE//usuE2wq7OsBIekuM2ipirmmhtz371VPk/RYgkax+eLF0TeeKAKxZeQ X-Received: by 2002:a17:902:7293:: with SMTP id d19-v6mr2046454pll.142.1528835830440; Tue, 12 Jun 2018 13:37:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528835830; cv=none; d=google.com; s=arc-20160816; b=Lq0idX3b/IpS89vFmhKlNpNv72VamyScK1SvDcMyT1bqpnBk6eeYmI5bBMDOfV9ANQ DPesrqoS0Q4dNnCadklCbMUuUG5pKjp7yhTw35VtjXReI73lJtVvOhzplXtykGmjJMI3 NJW2syg7hflVkTC5uql2ghtGAvxiYv2YEBeJlWA88TCBeOaJtnYhoPwmNHM7pYlEdwAy obdNeo0SMlqvKQnRqfPUC/O023jZD7II5Q8ZlZpSPE7qdAvD2QJF1R5dqxt78bEsIkrM HItgQk6RApqE60MANcUOeubPyNfd5bBiyZErTA7t0u9SXjcbjCdVKgo7OxCedSvEohE8 0zkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=LHo7fBBHDOTFCj5I1ZWDwsAXRQe84Ak97YbUzlqS5YQ=; b=I3sjczbDtzq5nOmFWngw//A+0k1LaNmLu+OAZD4yWKEGtaEl9q0uTYyUSg8uImC7uC Em+TSYjhoHytVvdlxmzZd+zAqR3oRDdDlX9yA1t4Pu1DwNFkttijbWp/Ku3bs5Zc8DZQ gZXBU6tQ5cw8tS2v+lZHeoNdFPWuRwcXwkaNdKSrPkn6kfHw1U0Jm4IKQAW1SJ/gwV0L 3l7IeRLNeIRezBCfbsaxSiFJ2scgDe4HkPp91Ntp/yKi/HnzpecpHfV7WqRh9gfXgcKz C4wyA9S5VuIgbQXyZr3h4kS8SsEaxHkrsUbNHG35DW7mJqfQu0lG3+5MImdGp8/yQ0Pt EwAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="K/3Dm0am"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n9-v6si765681pgv.501.2018.06.12.13.36.55; Tue, 12 Jun 2018 13:37:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b="K/3Dm0am"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934525AbeFLUg1 (ORCPT + 99 others); Tue, 12 Jun 2018 16:36:27 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:39625 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933175AbeFLUgZ (ORCPT ); Tue, 12 Jun 2018 16:36:25 -0400 Received: by mail-pg0-f65.google.com with SMTP id w12-v6so122152pgc.6 for ; Tue, 12 Jun 2018 13:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=LHo7fBBHDOTFCj5I1ZWDwsAXRQe84Ak97YbUzlqS5YQ=; b=K/3Dm0amJOrn/mtbLNYpnWJdoWoNEe9AsA9Uak9Ajs7N+tznZPMtulJ4SVTcnGy/mM fhbi0OVIOOwazbLEicCNbz36HRZYJYPrr+UUcsJsdEn+hrrHBJxiJtfx6RHtDJ6z1p1w V5zVLNtcfbRsbbe0HN2Rg3neT6S9WAYpdFvGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=LHo7fBBHDOTFCj5I1ZWDwsAXRQe84Ak97YbUzlqS5YQ=; b=g1RYLNc8OVS5JKvbBdYMoGLoZJWKe3dV+NmDVPATJyAecKa5+narCe1aYm01zc8HWn 7SiT14F+5KJH3Mrc7LjG1LF2HGJR2FeJ0/1eWqrviggQN8DaNjejIWNKBAcQhLnDjH71 OPDYjJNKSpbaaJ91vp/JlWZoC3vNrRraM8evxLgz22oPwGC8NxBzKC0qJ7E5tEfypxJq i8a/Dye1CZX2e0RwdVAaJ0/daO4n9C+MymbFErCGdzlBZDihUZxW1+ohboLpCe8hm9/2 rfCLdbwlwRqcwNQdNEp6xfePnE5N9RSqg+Tq38/A096IzoKYouDrB1R3Xhq2V3JwgQgy TzUg== X-Gm-Message-State: APt69E049by6C4MLDU9zZ6WlSnpNYLA75fkIoDy+F6xd2x8DE4cd641r MDLNEAld9yqr8LbvMJvVJBk8JqVE0Cs= X-Received: by 2002:a65:5807:: with SMTP id g7-v6mr1582459pgr.259.1528835785165; Tue, 12 Jun 2018 13:36:25 -0700 (PDT) Received: from [10.69.55.99] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id r188-v6sm1073387pgr.78.2018.06.12.13.36.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Jun 2018 13:36:24 -0700 (PDT) Subject: Re: [PATCH 4/5] nvmet: use atomic allocations when allocating fc requests To: Sagi Grimberg , Johannes Thumshirn , Keith Busch Cc: Hannes Reinecke , Christoph Hellwig , Linux NVMe Mailinglist , Linux Kernel Mailinglist References: <20180515074043.22843-1-jthumshirn@suse.de> <20180515074043.22843-5-jthumshirn@suse.de> <3c91cf45-aa85-e1a5-6d25-5654131626dd@grimberg.me> From: James Smart Message-ID: <9331096f-8e5c-d029-e41c-96d5fa8b14fe@broadcom.com> Date: Tue, 12 Jun 2018 13:36:22 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <3c91cf45-aa85-e1a5-6d25-5654131626dd@grimberg.me> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/2018 2:31 AM, Sagi Grimberg wrote: > > Question, why isn't tfcp_req embedded in fcpreq? don't they have > the same lifetime? > no they don't.  To properly simulate cable-pulls, etc - the host side and controller side effectively have their own "exchange" structure. tfcp_req corresponds to the controller side. The lifetimes of the two halves can differ. -- james