Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 12 Jun 2018 20:36:17 -0400
From:   Hugo Lefeuvre <hle@owl.eu.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, kernelnewbies@kernelnewbies.org
Subject: Re: [PATCH] staging: pi433: add mutex fixing race condition when
 accessing tx_cfg
Message-ID: <20180613003617.GA2265@hle-laptop.local>
References: <20180612011200.GB1794@hle-laptop.local>
 <20180612110230.dvqmcyisdwaynixj@mwanda>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
In-Reply-To: <20180612110230.dvqmcyisdwaynixj@mwanda>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> We read the data from the user here and then we write it to the fifo
> in pi433_write().  We should be using the device->tx_fifo_lock so that
> we don't copy over the data at the same time we're writing it to the
> fifo.

Oh right, that makes the bug even worse.

In this case we don't even need to introduce a new lock, using
device->tx_fifo_lock should be fine. I'll update the patch.

--=20
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA

--AhhlLboLdkugWU4S
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE5LpPtQuYJzvmooL3LVy48vb3khkFAlsgZvkACgkQLVy48vb3
khnTcgf/TQQQCNinka6VClKLUfIebQJ385tfDxD4ggUyB+gt+llBOVaPqHUHVzo7
xKey2McFoLEQaRaYwSdj5uuBI4getT0oYCf2jQn+sHSLJhxf7OdJdzezUlA9dgcd
LRydvUhYauqRaQGKYuqpkgBLIqPy9GULMzPGTasS60nt3P3jiJCoNJcG8CRbZTxR
3xctA1UJnCtCBpL03Fl8Spr7Avw6J/doy+ITqEhS6Bt0IvqHNAJS6ol85whWPqfP
p13RWo17LPsAyFAXWDWMkHCtsi7x0lhh1DxuNHGYWsFAeAkri5bvkxImpcp9VzJo
a/eqVhxKY3EX0fD+2U4PSKMjGwNyVg==
=xsIr
-----END PGP SIGNATURE-----

--AhhlLboLdkugWU4S--