Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp312949imm; Wed, 13 Jun 2018 00:24:11 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL3ppaX7nOOVd9f8QjTVwRf+S3FaCxi0GrA6KaDtqHR5KiTfQ/sI7+UoiqS+H+WJ8D+L5HT X-Received: by 2002:a62:4ad3:: with SMTP id c80-v6mr3736159pfj.23.1528874651745; Wed, 13 Jun 2018 00:24:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528874651; cv=none; d=google.com; s=arc-20160816; b=NzEJxq8cBjzQPZW0jAuW/Exk5fhtjwaB59cGLju/1NDzPB7LYigCBWBo02ElTiih6e MfdBDTwXfY0t6YhcFa4y1nakmzFjriQ9qsn/0jBPpaavnq2Tdu46Fvbpm9CS68OmyvWX VdrH5pkhV45tKukfzh43RAgauhD1DaQGGf18SQWVgMNeu22j2Is8G26sLX3PMLDc54J0 wpsrkV323XyZwedbpyJzjEZOYI9lINUV/JM1dHPcULGYArn5wfPNr9u7uOK34DFywBU4 JUIuaiJa6lPY0om4jUFSHSpzZDxD/H791nkyqSR+cXOVOoM0VPUWL3ziltnpW1IvAIYc X2Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=fyfJCRhZ2ft+ylu9AHXd2vApAWoAmi/3yo7VcAyUokM=; b=Kal5k/gqXA9YQy+JvbR1drP4tYGNnA5yvf4rib2fL+TS2NdXS7VOsNkk59QWzc5J7K 590w71adtXqw37BOmO8NEdVZYOQG+VBMAlc1I8Ek3gpclKycwFSIUv1tEXDyXxuIJDGB ZOADlV/od3C+fc2OoWE/u9wIeLZ6INYrZMLgGrqLZYCg1K1nV+x6h9vpfzeZgr6wHdOU B5WXXYdDhgSjx+m0mHESPhb5iNx0kavwhqRx/kEmzpUJ6OqIYoiwsE7coiiPIAJoN72E 2HYp6P60JX4/vabcPD2zH+3dsNVg+VOxf+NfiSobrAxsM07C5TAGDweswzNUIhYm7iTp /dVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZUilLF8C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r9-v6si1717104pgf.664.2018.06.13.00.23.56; Wed, 13 Jun 2018 00:24:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZUilLF8C; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934738AbeFMHXI (ORCPT + 99 others); Wed, 13 Jun 2018 03:23:08 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:60321 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934150AbeFMHXG (ORCPT ); Wed, 13 Jun 2018 03:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=fyfJCRhZ2ft+ylu9AHXd2vApAWoAmi/3yo7VcAyUokM=; b=ZUilLF8Cc6Kngg12PfjY86zrWD9Mb13H124g5ilMELFfv5DjrQn9j0Sl6MT3dFO5DTUt+HWPD5F5k7QoLHbaIBn2XnqaQy2tWcUC+NaH31AxzaCkzhC/cdYH1YFfrE0RvZVHa6hgDCqx/XGZHqqRMh+0L3XyfTxZym6gEPiz7mw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fT07R-0006gF-GG; Wed, 13 Jun 2018 09:23:01 +0200 Date: Wed, 13 Jun 2018 09:23:01 +0200 From: Andrew Lunn To: Radhey Shyam Pandey Cc: davem@davemloft.net, michal.simek@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] net: emaclite: Fix MDIO bus unregister bug Message-ID: <20180613072301.GC24314@lunn.ch> References: <1528871719-1681-1-git-send-email-radhey.shyam.pandey@xilinx.com> <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528871719-1681-3-git-send-email-radhey.shyam.pandey@xilinx.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 12:05:17PM +0530, Radhey Shyam Pandey wrote: > Since 'has_mdio' flag is not used,sequence insmod->rmmod-> insmod > leads to failure as MDIO unregister doesn't happen in .remove(). > Fix it by checking MII bus pointer instead. > > Signed-off-by: Radhey Shyam Pandey > Signed-off-by: Michal Simek Reviewed-by: Andrew Lunn Andrew