Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 13 Jun 2018 10:27:00 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     kernel test robot <xiaolong.ye@intel.com>
Cc:     mingo@kernel.org, oleg@redhat.com, gkohli@codeaurora.org,
        tglx@linutronix.de, mpe@ellerman.id.au, bigeasy@linutronix.de,
        linux-kernel@vger.kernel.org, will.deacon@arm.com,
        dzickus@redhat.com, lkp@01.org
Subject: Re: [lkp-robot] [watchdog/softlockup]  4808e7a5dc:
 BUG:KASAN:null-ptr-deref_in_h
Message-ID: <20180613082700.GV12198@hirez.programming.kicks-ass.net>
References: <20180612161832.428662402@infradead.org>
 <20180613050838.GK12146@yexl-desktop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180613050838.GK12146@yexl-desktop>
User-Agent: Mutt/1.9.5 (2018-04-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 13, 2018 at 01:08:38PM +0800, kernel test robot wrote:
> [    0.037000] BUG: KASAN: null-ptr-deref in hrtimer_active+0x70/0xa0
> [    0.037000] Read of size 4 at addr 0000000000000010 by task swapper/1
> [    0.037000] 
> [    0.037000] CPU: 0 PID: 1 Comm: swapper Tainted: G                T 4.17.0-11348-g4808e7a #1
> [    0.037000] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1 04/01/2014
> [    0.037000] Call Trace:
> [    0.037000]  ? kasan_report+0xe3/0x360
> [    0.037000]  ? hrtimer_active+0x70/0xa0
> [    0.037000]  ? hrtimer_try_to_cancel+0x17/0x210
> [    0.037000]  ? hrtimer_cancel+0x15/0x20
> [    0.037000]  ? softlockup_stop_fn+0x11/0x20
> [    0.037000]  ? lockup_detector_reconfigure+0x25/0xa0
> [    0.037000]  ? lockup_detector_init+0x51/0x5d
> [    0.037000]  ? kernel_init_freeable+0xa9/0x243
> [    0.037000]  ? rest_init+0xd0/0xd0
> [    0.037000]  ? kernel_init+0xf/0x120
> [    0.037000]  ? rest_init+0xd0/0xd0
> [    0.037000]  ? ret_from_fork+0x24/0x30

ARGH, I thought I fixed that one..

I think that'll cure things, but let me do a KASAN build myself.

--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -587,8 +587,8 @@ static __init void lockup_detector_setup
 		return;
 
 	mutex_lock(&watchdog_mutex);
-	softlockup_initialized = true;
 	lockup_detector_reconfigure();
+	softlockup_initialized = true;
 	mutex_unlock(&watchdog_mutex);
 }