Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp477031imm; Wed, 13 Jun 2018 03:40:14 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKl1RSjLPoMa/qLRqXc8DLyXuA2P2mceDAxccwKqGwb3JxCf6HM+ZBjWTsngX9SavacQQHg X-Received: by 2002:a17:902:6bc7:: with SMTP id m7-v6mr4698631plt.162.1528886414037; Wed, 13 Jun 2018 03:40:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528886414; cv=none; d=google.com; s=arc-20160816; b=sXIiUJzNttAmVCJVdMLFbsy1V3mhcdQL5vR41AGzmUbEAcnPQ5RwNDY5HeF0zQCWck rSu5foeh6fgBIkeKpVIq6wmyKwr2RbK50IT7+BZ76gszetEikIievd/v7FwpfsilULAZ ydcwqEwf5hSkXCMtVb02tkHCMGCPTEt6ZOrWpNEhRy5th/4oEbiRDlw9iNbjwhXIMonJ ocZj00/5BY4INLEGdAPakF01NGOxS3njHW7mf5bVdWp+6jsSb7dOdqJxruif9rQH3608 Cp8KrIv74foyrYeg+fMwlJNjbzfWDQfXGtwNU3N909UWvgFmyFlBWzR7DHxwsaPmcpPB I+Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:references:in-reply-to :message-id:cc:to:arc-authentication-results; bh=XPfgh2u+OMyRnsn5PEe0W641WgAq1lgMXu5x8kOVIQU=; b=SYSpPQKfZpjZyshY7M/KcGYlFcvGr+4ZZdcgZR0hBEpLvXOIYdEo38bOyeShTrvdOT qkeJyn65Daka154liPi7zuBhhqxCDJC4FhbO93ewd61zIk0jM23WFnZCmU6RE9ddFkrE QJCb89eyUAzm6AnEFyt2PHntA2eHK4Yhh7SUK5+9IDcvAnbR7MWoRYse9YjBse3JCvR7 F1xSQ9U/Yc81qokuGEMA8cC3/p5Ww0JT8QEc+0UUCQgfZcu6y9J6kq6VJKoLdWgRoWc3 bHitOu09kkQVEjbyMjLl0m4cIvse7rHjEPScb/uUGeQhOlHhpzALZxoqY0W4XZcKQRC9 XTtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b6-v6si1995897pgv.595.2018.06.13.03.39.59; Wed, 13 Jun 2018 03:40:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935260AbeFMKiF (ORCPT + 99 others); Wed, 13 Jun 2018 06:38:05 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:47898 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935060AbeFMKiC (ORCPT ); Wed, 13 Jun 2018 06:38:02 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id AB3AE27768; Wed, 13 Jun 2018 06:38:01 -0400 (EDT) To: Benjamin Herrenschmidt Cc: Michael Schmitz , , , Message-Id: In-Reply-To: References: From: Finn Thain Subject: [PATCH v3 03/12] macintosh/via-pmu: Don't clear shift register interrupt flag twice Date: Wed, 13 Jun 2018 06:38:01 -0400 (EDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The shift register interrupt flag gets cleared in via_pmu_interrupt() and once again in pmu_sr_intr(). Fix this theoretical race condition. Tested-by: Stan Johnson Signed-off-by: Finn Thain Reviewed-by: Geert Uytterhoeven --- drivers/macintosh/via-pmu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/macintosh/via-pmu.c b/drivers/macintosh/via-pmu.c index 74065ea410bd..4c1bae5380c2 100644 --- a/drivers/macintosh/via-pmu.c +++ b/drivers/macintosh/via-pmu.c @@ -1458,7 +1458,6 @@ pmu_sr_intr(void) if (in_8(&via[B]) & TREQ) { printk(KERN_ERR "PMU: spurious SR intr (%x)\n", in_8(&via[B])); - out_8(&via[IFR], SR_INT); return NULL; } /* The ack may not yet be low when we get the interrupt */ -- 2.16.4