Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp477781imm; Wed, 13 Jun 2018 03:41:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKBJt/2wyIEDtdzv2fmfcYA7iuntgB1Kg+3haYDmtRW48Rp7ZaSKj2cOqaOAIh3UHwlAIJX X-Received: by 2002:a62:9f16:: with SMTP id g22-v6mr4279933pfe.207.1528886467625; Wed, 13 Jun 2018 03:41:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528886467; cv=none; d=google.com; s=arc-20160816; b=H/Ctl3BBZ2LlwItxJ0t5zojwauSurdRZ3hDuRbwq/sJqMBnAhtJURjvyAaXenUjV1l Gp3lVTCa4pP/mhfvBA1t7cI8mlIDVAcmKW6udWgnocAMQp/aQDUgHq744BSGwQN56WDw SByqPpOG/M979P1t2JgRvsvXqyLBydNGyvseKP8oprqMEh16uuR6hnNnxkeQSTjgSApR +Ib2Sn07ayo1sVOdLRZNnbGR90q9hdUeu5+CB3oY8nOB7akZYtydOlv6JQj/CLtuwubQ 8HYS9E22ZLZ7mMiIUw5ZgAfhlOUEynD6KFU4FMasPF/60Kbf+v7PAAwe9gNVA23GUUPv 4JaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:message-id:cc:to :arc-authentication-results; bh=qwGZsKYAs/OR8nx1jR2tffKYrnNL/Zq/UstKlYss6tU=; b=H7F8REFwyWduFuIASCGWYPZr2g0nuy9rIg+SkL9wa/IdQTyrPOkgo4nrqcGLgyTCHy Y1mvLrUIF3qux0IYdZUk/qhgo24wcBjW9fORJT0lPwnchQT407+BzXmxS1bTkRuSPFjR eFzXXJqeSJHZRSYR6bTqHtb5/y6huJtjw56aEVgi6Tz1Fjxb6FwSSwcWWBOrbwEuhGex Gv5OYil56N6S9WMfpORqRze0dlq1dYud3hF/9Pd6Pw5CA+nX3Xl/VlDXpxanzERnntDZ kbsr5ab6vczWqOjxIoRoD+q8dpUl7Hj867tw+zjDrPuhPpPeHCktlgO4ZIoPbz+3tqoE L6aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6-v6si2190246pgt.470.2018.06.13.03.40.52; Wed, 13 Jun 2018 03:41:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935426AbeFMKju (ORCPT + 99 others); Wed, 13 Jun 2018 06:39:50 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:47884 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935183AbeFMKiC (ORCPT ); Wed, 13 Jun 2018 06:38:02 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 758DF267F1; Wed, 13 Jun 2018 06:38:01 -0400 (EDT) To: Benjamin Herrenschmidt Cc: Michael Schmitz , , , Message-Id: From: Finn Thain Subject: [PATCH v3 00/12] macintosh: Resolve various PMU driver problems Date: Wed, 13 Jun 2018 06:38:01 -0400 (EDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series of patches has the following aims. 1) Eliminate duplicated code. Linux presently has two drivers for the 68HC05-based PMU devices found in Macs: via-pmu and via-pmu68k. There's no value in having separate PMU drivers for each architecture. 2) Avoid further work on via-pmu68k that's not needed for via-pmu. 3) Fix some bugs in the via-pmu driver. 4) Enable the /dev/pmu and /proc/pmu/* userspace APIs on m68k Macs by adopting via-pmu. 5) Improve stability on early 100-series PowerBooks by loading no PMU driver at all. Neither via-pmu nor via-pmu68k supports the early M50753-based PMU device found in these models. 6) Eliminate duplicated RTC accessors for PMU and Cuda. Presently these can be found under both arch/m68k and arch/powerpc. 7) Assist the out-of-tree NuBus PowerMac port to support PMU designs shared with the m68k Mac port (e.g. PowerBooks 190 and 5300). This patch series has been regression tested on various PowerBooks (190, 520, 3400, Pismo G3) and PowerMacs (Beige G3, G5). These patches did not affect userland utilities. (Note that there is a userland- visible change to the contents of /proc/pmu/interrupts.) Changed since v1: 1) Added blank lines after 'break' statements in patch 10. 2) Improved patch description for patch 3. 3) Added reviewed-by tags. 4) Split patch 8 to make code review easier. Changed since v2: 1) Added reviewed-by tag. 2) Retained PMU_68K_V1 and PMU_68K_V2 symbols. Finn Thain (12): macintosh/via-pmu: Fix section mismatch warning macintosh/via-pmu: Add missing mmio accessors macintosh/via-pmu: Don't clear shift register interrupt flag twice macintosh/via-pmu: Enhance state machine with new 'uninitialized' state macintosh/via-pmu: Replace via pointer with via1 and via2 pointers macintosh/via-pmu: Add support for m68k PowerBooks macintosh/via-pmu: Make CONFIG_PPC_PMAC Kconfig deps explicit macintosh/via-pmu68k: Don't load driver on unsupported hardware macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver macintosh: Use common code to access RTC macintosh/via-pmu: Clean up interrupt statistics macintosh/via-pmu: Disambiguate interrupt statistics arch/m68k/configs/mac_defconfig | 2 +- arch/m68k/configs/multi_defconfig | 2 +- arch/m68k/mac/config.c | 2 +- arch/m68k/mac/misc.c | 118 +---- arch/powerpc/platforms/powermac/time.c | 74 +-- drivers/macintosh/Kconfig | 19 +- drivers/macintosh/Makefile | 1 - drivers/macintosh/adb.c | 2 +- drivers/macintosh/via-cuda.c | 34 ++ drivers/macintosh/via-pmu.c | 378 ++++++++++----- drivers/macintosh/via-pmu68k.c | 850 --------------------------------- include/linux/cuda.h | 3 + include/linux/pmu.h | 3 + include/uapi/linux/pmu.h | 4 +- 14 files changed, 313 insertions(+), 1179 deletions(-) delete mode 100644 drivers/macintosh/via-pmu68k.c -- 2.16.4