Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp554255imm;
        Wed, 13 Jun 2018 05:00:14 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKKzdGwVOqU3z0uitErvHcg5uG/UShjm6+jMCsSiCBg8jmf9dzo8aMTtIs/XVD/e6jlNoQxf
X-Received: by 2002:a17:902:5a09:: with SMTP id q9-v6mr4864529pli.300.1528891214664;
        Wed, 13 Jun 2018 05:00:14 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1528891214; cv=none;
        d=google.com; s=arc-20160816;
        b=r+aGMcoJjghJqUmk1hw7yCikW2hhVEUUsmiaK9nPfQrTZ+VzyahPq0PwTKkqEDWgCk
         pYeO4oCnDdU4w6m2aYzV5/ZhRtx+sd0t5+XdEQYLcqNGZ/z09F63aPcneMwi/Wra4w9e
         CHpCkcbni0N47LA+QlxhHThcWQ68QDfnKNWrBFdy6bxnRS6IrYLMWPGNguuQg9i83GQs
         fVzVIlLDmnG17iqEWtXViARj6LXXVNO0FQ21JfLz2tyK2MiNPwe7Kdsco+RU4MmDpEk6
         n/aSieo88rjdsDZy8s9tN4rRiRGCDA66nsGgrmEwKu13SdGKUEA19qr3WaDsmBLFsCQh
         MKoQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature:arc-authentication-results;
        bh=3+8kOIdUjpRPRoytKNLWNnNmgjFA6N/QiaLH0nJLreQ=;
        b=h4g52EBKlYI4DAaeWASzCEUTyLCfTF39uNqGEXXeJOdNKICjkCVrUw+T1dT0wWeqnu
         1bce78WaOzAz5wXrlN1mQbt2X/eNDogQB2CX2Yk03NHsimUUiDuE9ESrwCxqPkYhgGo9
         kZz4czgUTOc0Er8VwWQbyOjNhyBj6BPqLyt3lg6hpbf3r2lRYWVvRgJM3BI60ZHhIOVB
         CmNvts9s5yk2oij5W7345uHRoqFYNcoZDXWZXVh99IwHpVcdhf5JsfRtflowlTrlWhLR
         YSId9LtfkkJvctdVRBxmSTt00R/ykK1bHXk834zXNbB37OfIFgEULsbybPBsXbpMGE6f
         669A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=VtKgdb0H;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 9-v6si2697021ple.104.2018.06.13.04.59.59;
        Wed, 13 Jun 2018 05:00:14 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=VtKgdb0H;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935406AbeFML7d (ORCPT <rfc822;vladislav.valtchev@gmail.com>
        + 99 others); Wed, 13 Jun 2018 07:59:33 -0400
Received: from bombadil.infradead.org ([198.137.202.133]:42444 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935242AbeFML7c (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Jun 2018 07:59:32 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=3+8kOIdUjpRPRoytKNLWNnNmgjFA6N/QiaLH0nJLreQ=; b=VtKgdb0HLP6TqI8F9KXIWIyGM
        TGHl+iQ910lESOjQZxkcdRmkpy475ar0QaoI/YLJJqHj8H38g5gjtsmXcXukZEG9CHJgCyVUgJyXz
        bdlOeFD7sipiaUMTxzgfUX7OR5q5F283wY7e8aDYsJPcnNnh3ajQbpvMy9X7JpsN3jaqE1Hgf7JZX
        gbm8I7vEt6eiKM0sfnqAJjdlylzOycTUXtAFTEoSYDnlPyQIUiqZIZgsJaMzdoWKw8Up6oeiBP6f1
        16ZmWa6HyYsU7VuB8w76CgIbK+JYhLEzvpZGYoyobU0ukQxFbqb58XS5sS2DbR39Ctl5fooNJIADv
        mNhj+cdJg==;
Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux))
        id 1fT4Qz-0004e9-QO; Wed, 13 Jun 2018 11:59:29 +0000
Date:   Wed, 13 Jun 2018 04:59:29 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Johannes Thumshirn <jthumshirn@suse.de>
Cc:     "Martin K . Petersen" <martin.petersen@oracle.com>,
        Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] scsi: don't add scsi command result bytes
Message-ID: <20180613115929.GC12438@infradead.org>
References: <20180613075349.7509-1-jthumshirn@suse.de>
 <20180613075349.7509-4-jthumshirn@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180613075349.7509-4-jthumshirn@suse.de>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 13, 2018 at 09:53:49AM +0200, Johannes Thumshirn wrote:
> Some drivers are ADDing the scsi command's result bytes instead of
> ORing them.
> 
> While this can produce correct results it has unexpected side effects.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> -			cmd->result = (DID_OK << 16) + (l & STATUS_MASK);
> +			cmd->result = DID_OK << 16 | (l & STATUS_MASK);

Although I would have keep the braces around the shift operators
to stick closer to the original code.  But the code should be fine
even without them.