Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp554301imm; Wed, 13 Jun 2018 05:00:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKm9RGfw7UUCBN7LkJzmfHpY28qjU5d4ri5ncdhfuDjK4s4vDnKwrPOAxK0GmdAcT+mZ0ek X-Received: by 2002:a63:ba02:: with SMTP id k2-v6mr3857237pgf.179.1528891216549; Wed, 13 Jun 2018 05:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528891216; cv=none; d=google.com; s=arc-20160816; b=OHKQ7wh7l+UZvGrg0N+mO3PVFlyXkdeHmhcOZIEK9VANLrn3g9i7Dc5CpUdx2Vk7X0 iosOpbgWybf0NKAZiwMvxn3vlfKJ6BW17hQib/k9+qC6lzVwJVGTYdpLpKkPpJxTRW0K 0SOj+Cwy0Rx0q6IOEzopb94ANla98b6o2mP+kORrXBRoCGMX6D02LYMD7WwZQmLWjUKn IETjn4HCz6H6n9wxaWwBoFRsrof3vEL6LblcYkCmTAcMT6arpBUZsFBTRDP1TI6vWImB SJM+YDRQavvj1kmnDtNFGWQBdJ3v355LglU8UfAsLURMAcEbQwmZ/z6+d/sWoLzp55zv ObaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=Fk2Yiqma8gMrVgqe7N8ODufD5s7YBzZY48mwm1IluqE=; b=I8fSk9y00I2SQ+b1j+noPIP0JSMElEeLMZOgOP1JbbBNBiOfajOFJISV3l7cZHp5Ir 4l68sG3dUfMyK2qAIvUdPGeEDFxWDXqBdPLXieK72a/Vtr6VT1VZT7Tg+mIOifWWp+W7 eOmVjYV7nq0n/bTxxxf0U5fRwpAqx/CszAFTuPIV+xBSM8De3HvajkGryoJOkDLVTIpU riIUVSmVmqiCv5vqfSjl9WUmjm7ksyoPzBgItbfFAU+ekpVnKaX9j3rg0ew+UNSbBIvW /tgYgovcxtotGRcGGbhZKhze7imkFUmcCT1k5wJPpiMyWNdx/5+WAXGtGQRuaP1ryT5B 7KBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=VAvcsjkt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 85-v6si2554528pfm.264.2018.06.13.05.00.02; Wed, 13 Jun 2018 05:00:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=VAvcsjkt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935480AbeFML6N (ORCPT + 99 others); Wed, 13 Jun 2018 07:58:13 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:40696 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935242AbeFML6L (ORCPT ); Wed, 13 Jun 2018 07:58:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Fk2Yiqma8gMrVgqe7N8ODufD5s7YBzZY48mwm1IluqE=; b=VAvcsjktIWEcZJsh79P1mOku9 MNGNPU8hshv80yLDixPt5wEPtbsHE34JhD2Ws1bipg4BN9D/v2Iz2GqpNAWB2pQ+iztcuObfG+gAE SPiK6r0sjAKSd9JY+vaIojMz5+2P0ku4e6sXIBqQFG8vWPHc/ChBfqaAt4biiFOR/yXOYZ4j0Ijrc GqnJwXbjRsQcLzRjHdyd/rXKxtQcU/tzEZr7D1Bv93YFX27rm+dhsgZWZGvlau++IHC8RhdVOd2Bq rC+4FAb7WYMSKj13H2+rdfKmrMdvdGIBz1RxwitW05765cV5GZW+6gGxqzsyyJmvd2D8AQ0gDAbzU BzWIep9bQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1fT4Ph-0003ZI-68; Wed, 13 Jun 2018 11:58:09 +0000 Date: Wed, 13 Jun 2018 04:58:08 -0700 From: Christoph Hellwig To: Johannes Thumshirn Cc: "Martin K . Petersen" , Linux Kernel Mailinglist , Linux SCSI Mailinglist Subject: Re: [PATCH v2 2/3] scsi: check for equality of result byte values Message-ID: <20180613115808.GB12438@infradead.org> References: <20180613075349.7509-1-jthumshirn@suse.de> <20180613075349.7509-3-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180613075349.7509-3-jthumshirn@suse.de> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 09:53:48AM +0200, Johannes Thumshirn wrote: > When evaluating a SCSI command's result using the field access macros, > check for equality of the fields and not if a specific bit is set. > > This is a preparation patch, for reworking the results field in the > SCSI command. > > Signed-off-by: Johannes Thumshirn Looks good, Reviewed-by: Christoph Hellwig