Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1528812229-53043-1-git-send-email-pbonzini@redhat.com>
 <CA+55aFwvE5G7MV7AV4naAXdbFoszc4JNKEj_QtYqpLFfa2RXtA@mail.gmail.com>
 <6570c00b-bbec-82c3-16e2-1ba96d8e263b@redhat.com> <87y3fjossx.fsf@vitty.brq.redhat.com>
In-Reply-To: <87y3fjossx.fsf@vitty.brq.redhat.com>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Wed, 13 Jun 2018 07:00:37 -0700
Message-ID: <CA+55aFx5n6VJWhY5uNGYWi7ZHhT=FWjDrNK3Q_h5RssNcT0mrQ@mail.gmail.com>
Subject: Re: [GIT PULL] KVM changes for 4.18 merge window
To:     Vitaly Kuznetsov <vkuznets@redhat.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        KVM list <kvm@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 13, 2018 at 4:00 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> This was reported before by Arnd Bergmann:
>
> https://www.spinics.net/lists/kvm/msg169536.html
>
> but it seems his patch got lost.

So I think his patch is closer to what the code *should* do. Mine was
a big ugly #if around the whole thing, but I really think that *all*
those

     if (static_branch_unlikely(&enable_evmcs)...

cases should probably be using IS_ENABLED(CONFIG_HYPERV) too.

Preferably by simply having a helper macro or inline function to do both tests.

I intentionally did just he big brute-force thing, I'm hoping the kvm
hyper-v people will clean this up.

But obviously this also showed a lack of testing.

                    Linus