Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp751654imm;
        Wed, 13 Jun 2018 07:46:23 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKJkUWzoNGk7A6fb0m1xjzbdz6nh8apGfqKDNC8CwGToG4XtrXtBgto3Q9qKN7b6nxuexNz7
X-Received: by 2002:a17:902:b683:: with SMTP id c3-v6mr5547387pls.158.1528901183537;
        Wed, 13 Jun 2018 07:46:23 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1528901183; cv=none;
        d=google.com; s=arc-20160816;
        b=ExDWO/C6copeEpanem1Kt8iCKGmrGomwSo+5z7cJzuvxEQV86FBxRbULW3zXV7gDza
         BdpcsimkHtMJYI4kopMcpvtNjfbKxV1cx5MTxcb2g9ZRQpTVEwyEkFA+ZtvX4ObwVH9I
         LQaBDNgo/i+f7CxYWi3DxcK5OL9PthdX9Q01jjNzbSXPB7PH0u61mupoDpAD76eOwa65
         EF3700lqK05gxc1m2tQPgmKGLWTnB10/9h6u66SO798m8J+yhzWyjpAt8DS7VC8FnoLE
         SJ7mn/hj4xhu3X2s59S3LsaJuqtZZ3yKK+NB+0OQjVIVdDaRXMyuujbpdebk0gnHCU92
         TVmg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature:arc-authentication-results;
        bh=Gytpz5v+1VuiNmO3PtrD+QFBfJEzK8sXBUI1oTl8xs4=;
        b=0mEKnotb/nw8tK96Jir2eZ74llmKAZ3fVrsOUD8n3bAk6oRSZg5R4ZLDXiIPVhmNgJ
         HzGC+z2omBxMP9APQKhdXJTA8RX3dw1c/DUQSu4/YWbk7PeNh8ZXUDdi6CTfCpw8lwnE
         D7uLZQnrHt7wnBTD6UV53CTPFHzyq1vE+R3SdL2n9xJRzEG/n1dIKCx/Xh7rMHCc6Fh6
         ybtUalLw8KelcSzLKSL1ysURBAXe4oOgJtQQEWV1Ydl8qbc+XcqsIF742sfbAwKUwhbn
         3dfEt+oDdZX5E5FQjNc2xv2PXwG3tJ7ulOVKSEUA3cnVgsnW/0n+d8k/SgPxOeT74orE
         eZnQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=C4VcTKfR;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id m62-v6si3120224pfa.45.2018.06.13.07.46.09;
        Wed, 13 Jun 2018 07:46:23 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=C4VcTKfR;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S935912AbeFMOo2 (ORCPT <rfc822;vladislav.valtchev@gmail.com>
        + 99 others); Wed, 13 Jun 2018 10:44:28 -0400
Received: from bombadil.infradead.org ([198.137.202.133]:44970 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S935659AbeFMOo0 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Jun 2018 10:44:26 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=Gytpz5v+1VuiNmO3PtrD+QFBfJEzK8sXBUI1oTl8xs4=; b=C4VcTKfRKagLNAq0hXQg/84jj
        4bSTMHluCufWMx6ohJ+G6zovGa10iGez/2AMiTW2zyUYfmxDmZAt/AEwh8ZG7756mSeESd0v/kDHp
        0nVgYN9pQvPs/D/iGDQoWQzGHLsHaly9JsBWox0BS/2nd0Usu1TS0Hnl8T45nmFs9QUuscP+XDNYr
        nCEZY3hD/EOAgc5gdy4QburdnRvgIuYGypEeO4nA2pKhdUDAji3L4WRG1TejiimdUGc8SB83foM5+
        WU+rAYrc46EBh0JAanBawsX7MTJJJQZvluogdYszno78iuawE8l/XkMURq8YFOXD5USyaaPOGinF6
        wWz3XbRyw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux))
        id 1fT70O-0007It-HQ; Wed, 13 Jun 2018 14:44:12 +0000
Date:   Wed, 13 Jun 2018 07:44:12 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Kent Overstreet <kent.overstreet@gmail.com>,
        David Sterba <dsterba@suse.cz>,
        Huang Ying <ying.huang@intel.com>,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        Theodore Ts'o <tytso@mit.edu>,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        Coly Li <colyli@suse.de>, Filipe Manana <fdmanana@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH V6 11/30] block: implement bio_pages_all() via
 bio_for_each_segment_all()
Message-ID: <20180613144412.GB4693@infradead.org>
References: <20180609123014.8861-1-ming.lei@redhat.com>
 <20180609123014.8861-12-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180609123014.8861-12-ming.lei@redhat.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Given that we have a single, dubious user of bio_pages_all I'd rather
see it as an opencoded bio_for_each_ loop in the caller.