Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp846355imm; Wed, 13 Jun 2018 09:10:04 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLNpdoD3pPXhkZBXQ4XBw9LjgdxEu2WCzW3WqCGhYhJkrVBhXW3DP+HUGEPMmx26SDfMXnG X-Received: by 2002:a62:1282:: with SMTP id 2-v6mr5520796pfs.243.1528906204458; Wed, 13 Jun 2018 09:10:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528906204; cv=none; d=google.com; s=arc-20160816; b=aizyhqepHecQaXaoQLXeh+rGP/HXouMZQ1WmhDEiRHvrOehcZyZVXHUbIut1jsN8b1 IFFk8VpktdBkijPZH/uwIpGc+pPE/5EXXPUB5iHk6hN6YvrvxT4HyXB2tmlW4c3GfUcE 1NHY/fOyQCsv53bQ1BQA5bzVJWYrBlva2l8/o9A0/9D0TVhD/hSevBPxBCMlHpMTwatW jNIH378dbYPmAYKoX6DeonQYAeVFR66yaUUPvUzcLKU6IOTnCoAmxwUTpCUHiV/ZTcVi En9tq3dKjIN9jf2znfxR977EZqBEHNLBv78zVpuLD6n9G7eh74dBF5is2aWqdE+I9/kl Ix5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type :content-transfer-encoding:mime-version:in-reply-to:user-agent :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter :arc-authentication-results; bh=M4ccvzf28c1i0EsNntMWHgnBwOFkxsMaHQN6yKtR2OI=; b=F9QXYRvlErGshwVLedLcOBGNqgP16347BMm+eCIOXb8++c+qeq6ecOcD/FSGF3Afa6 HNIwRKAOn/h951oJLbreZpDJHNHgwn9NKF+h4o5xX02NabWt+AambHo57ICBgQC8sGcm ko4XTtNRJbpughHzMwDDFhtnTomnmVBlJViz4p11bb8ABUsIeK0HQHuXMbWA1LeWYGE1 RAWkm3TVUqzGzNYomR4yJkrmkgZTpbW1ff5u4XrEU3lnBeeKPljfuz5P6YdXrtV3lz4M CJAuGRwZ9cnCJ5bKBh43s4So7Op5bZadWaHXOoVPYN/rxVnWG8Y/ypeq1uEIgBs4oO9x aPnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=rkyfrpX3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10-v6si3166948pfk.203.2018.06.13.09.09.49; Wed, 13 Jun 2018 09:10:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=rkyfrpX3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935147AbeFMQIo (ORCPT + 99 others); Wed, 13 Jun 2018 12:08:44 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:46825 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934563AbeFMQIk (ORCPT ); Wed, 13 Jun 2018 12:08:40 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180613160838euoutp01ef7d260a4a5edc485b5194b2207da154~3xAOihAmG0068200682euoutp014; Wed, 13 Jun 2018 16:08:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180613160838euoutp01ef7d260a4a5edc485b5194b2207da154~3xAOihAmG0068200682euoutp014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1528906118; bh=M4ccvzf28c1i0EsNntMWHgnBwOFkxsMaHQN6yKtR2OI=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=rkyfrpX3rPQRcJ2ZqNPKEDFpxOQHb3RglYaBqOete+TQrV65Xs+NUhPPmEVtSHAMe dT37Y4u0+p4TU+hNve2HzvOiEbK8Vtec37nlYypm/FMXLQGeZg4EhvReKAj/W1LkXh cRmLrX8gEXfAJzXLLywnZ4Iof8lrpakS8csaQNcA= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180613160837eucas1p143c5430d7be4efd786bbe2e336d50f27~3xAN5mx8G0612106121eucas1p19; Wed, 13 Jun 2018 16:08:37 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 43.F4.05700.581412B5; Wed, 13 Jun 2018 17:08:37 +0100 (BST) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180613160836eucas1p2877b4afb58fde464bdbc484875785f1f~3xAM_jQUg0874508745eucas1p20; Wed, 13 Jun 2018 16:08:36 +0000 (GMT) X-AuditID: cbfec7f2-1dbff70000011644-9a-5b2141851f0a Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 50.8E.04183.481412B5; Wed, 13 Jun 2018 17:08:36 +0100 (BST) Received: from amdc3058.localnet ([106.120.53.102]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PA90097CRIC9540@eusync1.samsung.com>; Wed, 13 Jun 2018 17:08:36 +0100 (BST) From: Bartlomiej Zolnierkiewicz To: Ard Biesheuvel , Peter Jones Cc: Sinan Kaya , "open list:EFIFB FRAMEBUFFER DRIVER" , Timur Tabi , linux-arm-msm@vger.kernel.org, open list , "open list:FRAMEBUFFER LAYER" , linux-arm-kernel Subject: Re: [PATCH V2 2/2] efi/fb: Convert PCI bus address to resource if translated by the bridge Date: Wed, 13 Jun 2018 18:08:36 +0200 Message-id: <6376822.ENUjdQ58sn@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42LZduzned1WR8Vog56l4hb/P+xmtLjy9T2b xabH11gtJu4/y25xou8Dq8XlXXPYLBonbWOy6Fp4g92i+bG6A6fH5b5eJo871/awedzvPs7k sXlJvcf7fVfZPD5vkgtgi+KySUnNySxLLdK3S+DK+P9nGVNBI0/F4YuH2BsYr3N2MXJySAiY SPzd0MDaxcjFISSwglHi3rV2FgjnM6PElyvfGGGq3k16yQSRWMYo0fxiCjuE85tRYu6FhSwg VWwCVhIT21cBdXBwiAgEShw6IwZSwyxwnUliS89eZpAaYYFUiSn7X4FNZRFQlWhqnAwW5xXQ lNj+fzsbiC0q4CWxZV87E4jNKRAs8fL2JxaIGkGJH5PvgdnMAvIS+/ZPZYWwdSTOHlvHCLJM QuAMm0T/gausEGe7SBzufMkOYQtLvDq+BcqWkbg8uZsFomE6o8SbX0uhnPWMEmvOHGOCqLKW OHz8ItQKPolJ26Yzg7wmIcAr0dEmBFHiIXFgwVFGSFDcY5ToWviFeQKjzCwk185Ccu0sJNcu YGRexSieWlqcm55abJiXWq5XnJhbXJqXrpecn7uJEZguTv87/mkH49dLSYcYBTgYlXh4N8gp RguxJpYVV+YeYpTgYFYS4fV7oRAtxJuSWFmVWpQfX1Sak1p8iFGag0VJnDdOoy5KSCA9sSQ1 OzW1ILUIJsvEwSnVwKh852JB7Bn7LUV7I++WSS7m7fy00bJ4ZeiPr2cP2y6dU8FukzRRW7cx rmf74/nrS489WCHCcMP9vmXp7ylhpkcuhe5Mt88KOtYiVb/Bvzbz3bNUm7YkS9viyWff7cmX Ofyp3DPAgMl294Yizw/8ovkCHEL1BmJWL/SnrOqcc2t2mtux8oSQc0osxRmJhlrMRcWJAG1l vR8TAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHLMWRmVeSWpSXmKPExsVy+t/xy7otjorRBm/eaVj8/7Cb0eLK1/ds FpseX2O1mLj/LLvFib4PrBaXd81hs2ictI3JomvhDXaL5sfqDpwel/t6mTzuXNvD5nG/+ziT x+Yl9R7v911l8/i8SS6ALYrLJiU1J7MstUjfLoEr4/+fZUwFjTwVhy8eYm9gvM7ZxcjJISFg IvFu0kumLkYuDiGBJYwSt3euYoRw/jJKfF6+mgWkik3ASmJiO0iCk0NEwF+i//kSVpAiZoGb TBLHPvxnBkkIC6RKTNn/CqyIRUBVoqlxMlicV0BTYvv/7WwgtqiAl8SWfe1MIDanQLDE7OdL mCG23WOUONi7kh2iQVDix+R7YJuZBeQl9u2fygpha0ms33mcaQIj/ywkZbOQlM1CUraAkXkV o0hqaXFuem6xkV5xYm5xaV66XnJ+7iZGYKhvO/Zzyw7GrnfBhxgFOBiVeHg3yClGC7EmlhVX 5h5ilOBgVhLh9XuhEC3Em5JYWZValB9fVJqTWnyIUZqDRUmc97xBZZSQQHpiSWp2ampBahFM lomDU6qB0a5A604c7057g10GupPSfB/3ZAZVfrHYXpQSKLCNfV9O9qedqY2CAdv4NQ9p9RV+ ljq8I7iObU/Wd3ubzxIHyy+UX7pRbFx1VOuYd8ay2LM269i2KWfq3uEq0hE8sDLF3kbShIez 65+uYE63uJLZ0+mL5ExNQyP+ra9aysVxLi335JLwlMlKLMUZiYZazEXFiQC/5P3ycQIAAA== X-CMS-MailID: 20180613160836eucas1p2877b4afb58fde464bdbc484875785f1f X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180613154552epcas5p4877f53310b66cf9d3e17196b0d028e41 References: <1526653072-7153-1-git-send-email-okaya@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 13, 2018 05:45:48 PM Ard Biesheuvel wrote: > On 18 May 2018 at 16:17, Sinan Kaya wrote: > > A host bridge is allowed to remap BAR addresses using _TRA attribute in > > _CRS windows. > > > > pci_bus 0000:00: root bus resource [mem 0x80100100000-0x8011fffffff window] (bus address [0x00100000-0x1fffffff]) > > pci 0000:02:00.0: reg 0x10: [mem 0x8011e000000-0x8011effffff] > > > > When a VGA device is behind such a host bridge and the resource is > > translated efifb driver is trying to do ioremap against bus address > > rather than the resource address and is failing to probe. > > > > efifb: probing for efifb > > efifb: cannot reserve video memory at 0x1e000000 > > efifb: framebuffer at 0x1e000000, using 1920k, total 1875k > > efifb: mode is 800x600x32, linelength=3200, pages=1 > > efifb: scrolling: redraw > > efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0 > > > > Use the host bridge offset information to convert bus address to > > resource address in the fixup. > > > > Signed-off-by: Sinan Kaya > > Reviewed-by: Ard Biesheuvel > > Bartlomiej, could you please take these via the fbdev tree for v4.19? Sure, I will queue it after the current merge window. > Peter already gave his ack but Sinan dropped it (presumably because of > the split in v2) Peter, can I (re)add your ACK to V2 patches? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics