Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 13 Jun 2018 19:13:20 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Keith Busch <keith.busch@intel.com>
Cc:     Ben Hutchings <ben.hutchings@codethink.co.uk>,
        Jianchao Wang <jianchao.w.wang@oracle.com>,
        stable@vger.kernel.org,
        Sasha Levin <alexander.levin@microsoft.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4.4 110/268] nvme-pci: Fix nvme queue cleanup if IRQ
 setup fails
Message-ID: <20180613171320.GB28828@kroah.com>
References: <20180528100202.045206534@linuxfoundation.org>
 <20180528100214.621806271@linuxfoundation.org>
 <1528906474.2289.155.camel@codethink.co.uk>
 <20180613163007.GD5574@localhost.localdomain>
 <1528907855.2289.157.camel@codethink.co.uk>
 <20180613165631.GE5574@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180613165631.GE5574@localhost.localdomain>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 13, 2018 at 10:56:32AM -0600, Keith Busch wrote:
> On Wed, Jun 13, 2018 at 05:37:35PM +0100, Ben Hutchings wrote:
> > On Wed, 2018-06-13 at 10:30 -0600, Keith Busch wrote:
> > > Thank you very much the catching that. This particular patch is indeed
> > > not correct without the following:
> > > 
> > > ? 161b8be2bd6ab ("nvme-pci: initialize queue memory before interrupts")
> > 
> > Oh, now I see.  Do you think that commit is suitable for stable
> > branches?
> 
> Yes, we can safely include that commit 4.4-stable. The scenario it fixes
> isn't very common in 4.4, but it could happen with quirky hardware or
> legacy interrupts.

It does not apply to 4.4.y right now, but it does apply to 4.9.y, so
I've added it there.  If it needs to get to 4.4.y, can someone do a
backport?

thanks,

greg k-h