Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1141008imm; Wed, 13 Jun 2018 14:08:26 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKGkVuC/j36DVsJAVEs5NoD0v8PbgQV0jEG2Vpqs/loGwBRbr12qiODaDd5wgW9kJPLyoTM X-Received: by 2002:a65:5c42:: with SMTP id v2-v6mr5478381pgr.224.1528924106169; Wed, 13 Jun 2018 14:08:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528924106; cv=none; d=google.com; s=arc-20160816; b=PrA0iHFquyZ6lZgtUVxl3ljcRjS36DQY83tFg7NfrGtxTEZ490nzLOhTrRTVKQ9TAT GWR/4RaI6JIHLfQGxsGIKpg9+NlMblu1VvsFnn6xEuRQWWmvT5d4lYjCTsqR4nfXenZV yvRRFEfjWfrJMi8KufDj5yQ2R1cUqIbBnQvNTYCF8EYXlbAmcujQvYhAxh64fIl3KueJ 83+rhMEYNj1Dy9+ZoFJKVmz7x0mH+POOzRjVLcfRuyqcD2D5TzJgpO7j4TSAPW5PZlWw KRF3kYGlS1bce+pPT4u+YZcUmRyqCjau6jrIyBOCLL9cUEmI3v6si+va9IlrYJLQJ619 bHtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=JSXnN+y8bSkLRGf7anPAQceKjNCO79+1QesmJcv08KY=; b=sMi9/xu8zTtw9PN7SjtQZmBNl9ST1bm7V0eElvbq5ZMmpuUpsx86hfY5iC75ibJjBB H+I9Rh4XAPPw5D5xILI60tLhSoq3KZ7hbpYCk9/KgrvRu+bQL8fJuqv5+cSpP78sgbrD +trk+m2464/MdL2M+2Yq/TVSg3u8Z2ShtghBlEqqOYnDj55CusnrEQDLxtipGPlz/bRf v0+50oJSbMUHL6YLCyHsVP7jeW9MzoCv81Z5dbOGz6nDt70fAI3pegLX/bmfCMwBASSS cpVDw6BiXqJjE+5j3p8BThwvvnzaz4pmclCeoE2BwVav7+zz7UMzNgAY9W7afDVgMxy4 Kq4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H3PRtQvH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u8-v6si3541569plh.492.2018.06.13.14.08.11; Wed, 13 Jun 2018 14:08:26 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H3PRtQvH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935963AbeFMVGU (ORCPT + 99 others); Wed, 13 Jun 2018 17:06:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:48988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935899AbeFMVGS (ORCPT ); Wed, 13 Jun 2018 17:06:18 -0400 Received: from jamesdev (jahogan.plus.com [212.159.75.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94A75208C4; Wed, 13 Jun 2018 21:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528923977; bh=Fh8lD1+cH6l73tS5bQbFh/xvuz+JZ7ouKETZ25IZEKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=H3PRtQvHyfOwh+4ezxKhdTviSf8bigs3+i7iUf7amq0mP6Wltl5e6HXvy2CwCFAUx DLpRgIndiddj8uKAq42H9O7JPAC74WuemQTQYXNsYWA3XNFWDhza5B74/ihMy/H5zf Juy09TAXtx4iwEAH5JqoosuFHa4vg00bO5FrzsTE= Date: Wed, 13 Jun 2018 22:06:13 +0100 From: James Hogan To: Guenter Roeck Cc: Greentime Hu , Vincent Chen , linux-kernel@vger.kernel.org, Matt Redfearn , Palmer Dabbelt Subject: Re: [PATCH] nds32: Fix build error caused by incomplete configuration flag rename Message-ID: <20180613210611.GA16086@jamesdev> References: <1528919032-4874-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline In-Reply-To: <1528919032-4874-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Thanks Guenter, On Wed, Jun 13, 2018 at 12:43:52PM -0700, Guenter Roeck wrote: > GENERIC_ASHLDI3, GENERIC_ASHRDI3, and GENERIC_LSHRDI3 were renamed to > GENERIC_LIB_ASHLDI3, GENERIC_LIB_ASHRDI3, and GENERIC_LIB_LSHRDI3 > without making the matching changes in arch/nds32. Well, thats a little misleading. The commit in question was applied based on 4.17-rc2 a month *before* commit aeaa7af744fa ("nds32: lib: To use generic lib instead of libgcc to prevent the symbol undefined issue.") raced and overtook it and was merged in time for final 4.17, so technically it was only when the two recently came together in merge commit 763f96944c95 ("Merge tag 'mips_4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux") that it was a problem. Incidentally, is anybody building linux-next for nds32? (I could have asked Linus to fix this up in the merge commit had I known). > Fixes: e3d5980568f ("lib: Rename compiler intrinsic selects to GENERIC_LIB_*") Perhaps this would be more accurate?: Fixes: 763f96944c95 ("Merge tag 'mips_4.18' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux") > - select GENERIC_ASHLDI3 > - select GENERIC_ASHRDI3 > - select GENERIC_LSHRDI3 > + select GENERIC_LIB_ASHLDI3 > + select GENERIC_LIB_ASHRDI3 > + select GENERIC_LIB_LSHRDI3 > select GENERIC_CMPDI2 > select GENERIC_MULDI3 > select GENERIC_UCMPDI2 These 3 were renamed also. Cheers James --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEARYIAB0WIQS7lRNBWUYtqfDOVL41zuSGKxAj8gUCWyGHQQAKCRA1zuSGKxAj 8vmKAPiOMlQvFT8ixEdDaGoMe/MOg+4c0W4jAFBKC/X+CxrPAQCZR1E7hXDToN2c IwwHtlK/1kWhPmuft0NmAocEwdlXDQ== =MWG8 -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6--