Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1228754imm; Wed, 13 Jun 2018 15:54:25 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIrIkZLKtgF1M31+s4MvPZDso1x1qT3r/WepzBO6go3X/UKDpkP6k/zms0htSQ7ABd/oGl7 X-Received: by 2002:a63:7b03:: with SMTP id w3-v6mr120870pgc.52.1528930465852; Wed, 13 Jun 2018 15:54:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528930465; cv=none; d=google.com; s=arc-20160816; b=EKDv5HCrxI8wkqF3YvTz6ey5go6XDxiU5XW04/cri63rcKrDy2keCWNv/Vx1na68Cz iNUzyrrXWuy+ZtlzJRtNF/uHD7xX6yHpBbNfbtuK5Ha8ogHPVZ113ktXIlUHUcBR0UN6 OjFxooRfE8tjHeRS9jSEGYAY+oZk/2RnaPOmsb9CIrIucZIqz0ZMaQuejRnqpNr+GVvV 0mFdfm4wk9vRV0ff09nP/7omAktej5NmbeBXHeSYgLghplJ9C17kVkDV21dXo0IlHkjQ gg4qeXQllq13rCCtCv8EjnQk2bDz95SfqSfOuU/JZHsvC37IIpb+NmExKjU9nKyfmwxY 4+IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=di4sob8CZAEp+h9G6WuBO3mjkXdwCMxHjNoV2I/WLBU=; b=BMY0N6Y2tUj9fivy8N/+ldu77W4zQ4TP5QCRG5uFHuvRUJMdrcljHLQCVpSiuzouO6 qSPS6qaX5gwfjVPCbTeUdUmMODoI7eDQV2OeWM/llFbJjSizB3M5J91Sl93LGD3Nz0P9 ckF7Ws2ZpU8w4wjKqc51DxHd8Sz9ToJtfZ3h088TI0NVhRSj0Gv0TCb4tLkzttETGQrh 6wTbJh2ikB62ViWMGgo9HPRzGkD476Z7WNIBHjvbFaErmMQ7YnBXsOaf6+xes6wVn62i wB5l8oSaPsoy1WuOOINF3JrEDfQcf35cUdVu+RsXfGhux0I2MPr7HY8dxUHWvfNqLRn3 gEMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="fF3B5D/8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p2-v6si3199149pgs.67.2018.06.13.15.54.10; Wed, 13 Jun 2018 15:54:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="fF3B5D/8"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935739AbeFMWx2 (ORCPT + 99 others); Wed, 13 Jun 2018 18:53:28 -0400 Received: from mail-pg0-f68.google.com ([74.125.83.68]:46856 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935432AbeFMWxZ (ORCPT ); Wed, 13 Jun 2018 18:53:25 -0400 Received: by mail-pg0-f68.google.com with SMTP id d2-v6so1958931pga.13 for ; Wed, 13 Jun 2018 15:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=di4sob8CZAEp+h9G6WuBO3mjkXdwCMxHjNoV2I/WLBU=; b=fF3B5D/8BEx7HO/BPEyk8LiR39sRlWqDwvEWakqxVelWb8eoAhn6NwCZBL3gVuud2r 2I5JvM+MPHRtkeATgH3mo3Ch1pGEG8luBXGtY8UX2VujOYFDMj9YAF0N5jV4xAizuuLN N/AHo259VUFUAKJJqpub229/NtqzEnuhhq8ys= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=di4sob8CZAEp+h9G6WuBO3mjkXdwCMxHjNoV2I/WLBU=; b=cAugTi3HQCrDZFSAVmU9CPJGk1dRLw+RYnWE5zrK6Sc/yVEVxTCaXPecYnqXW14Jys 0nE6gVQBVEZ/RrshxNMr81wgHH8mGQfWDbevauJOwX5rATXUYcAjbXqey6PpDWDCtCKM GDss3rMcOh/c+N993tu7qlgnkbnbYZ6CA1TrJnbDa7yH3Buuoyg4msb8XiHqTWlY7QSX /l6QU/u2n9Q1e/wPqtXox11KvNLZx4esqRi7MD+c9Y9PzvY7wT8JLRG3WoOjMBdAkAhl o/wm/QUr9u4b61JJFQgABrJ6KKjQd1IFQ53P9U5EZ8jiiqcbF+wWqnMmKFlb7IQ8KGaT xRpA== X-Gm-Message-State: APt69E23sYwY/WkLThcdpLlDSseEhEAIlmVyMKRg5+quRJqVdUxGYof/ nn738WrZo/8Poj4HypOgzAxQIoo53L0= X-Received: by 2002:a65:4389:: with SMTP id m9-v6mr68534pgp.383.1528930405184; Wed, 13 Jun 2018 15:53:25 -0700 (PDT) Received: from localhost ([2620:0:1000:1501:8e2d:4727:1211:622]) by smtp.gmail.com with ESMTPSA id v85-v6sm8408992pgb.50.2018.06.13.15.53.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jun 2018 15:53:24 -0700 (PDT) Date: Wed, 13 Jun 2018 15:53:23 -0700 From: Matthias Kaehlcke To: Craig Tatlor Cc: linux-arm-msm@vger.kernel.org, Sebastian Reichel , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , "David S. Miller" , Andrew Morton , Greg Kroah-Hartman , Linus Walleij , Randy Dunlap , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Message-ID: <20180613225323.GM88063@google.com> References: <20180407135934.26122-1-ctatlor97@gmail.com> <20180613160643.12638-1-ctatlor97@gmail.com> <20180613160643.12638-3-ctatlor97@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180613160643.12638-3-ctatlor97@gmail.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (sorry if you receive two variants of this mail, I sent one earlier today but for some reason it didn't make it to the lists) On Wed, Jun 13, 2018 at 05:06:24PM +0100, Craig Tatlor wrote: > Add bindings for the Qualcomm Battery Monitoring system. > > Signed-off-by: Craig Tatlor > --- > > * Changes from v5: > Mentions which values are 8 bit. > > * Changes from v4: > Uses proper units and expands some definitions, > along with changing vadc@ to adc@. > .../bindings/power/supply/qcom_bms.txt | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/qcom_bms.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt > new file mode 100644 > index 000000000000..9a29a2eb9f04 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt > @@ -0,0 +1,92 @@ > +Qualcomm Battery Monitoring System > + > +The Qualcomm Battery Monitoring System is found inside of Qualcomm PM8941 > +PMICs. It provides open circuit voltage (OCV) and coulomb counter registers > +that allow the OS to infer a capacity level. > + > +Required properties: > +- compatible: Should contain "qcom,pm8941-bms". > +- reg: Specifies the SPMI address and length of the > + controller's registers. > +- interrupts: OCV threshold interrupt. > +- io-channels: Should contain IIO channel specifier for the > + ADC channel that reports battery temperature. > +- io-channel-names: Should contain "temp". > +- qcom,fcc-temp-legend-celcius: An 8 bit array containing the temperature, > + in degC, for each column of the full charge > + capacity lookup table. s/celcius/celsius/ same for qcom,ocv-temp-legend-celcius > +- qcom,fcc-lut-microamp-hours: An array of full charge capacity values in uah, > + one entry for each temperature defined in in nit: s/uah/uAh/ Thanks Matthias