Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1342685imm; Wed, 13 Jun 2018 18:24:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLPR2FSR8S1joCzghymnnQmTLvB8X2Ava5tRs39wxncpmFbdoUCbpSAkKjB9AlKNYYWaI2I X-Received: by 2002:a62:6a46:: with SMTP id f67-v6mr7201008pfc.105.1528939495971; Wed, 13 Jun 2018 18:24:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528939495; cv=none; d=google.com; s=arc-20160816; b=WNDW54einbL3ja/Dz8naUQyfjY4+Q+FazccPWewFm5AxVLDGL04c5oeqTCgEsXct1w 3kyYEehzeI7VakoNhcZ2Dqk6eb4rywX2RAIOZesAdkb8pZwL0x2f1HqIMyJMDBAZEi48 uKrV7quHoGhNzj4qQusn3S0rZbuCoNbWCWnRP341PGP3EumyYvwx/rjjbfDBH6hk4sii T+69wWRnpLbZOoiEHIpeKa3xvTNrqb2Yaey8CtWoiry+twp0wVbcIcEvkboapa3HzQ5W embuh8nfaW7x0ip6ZMwb/SGSU/lhBgHVrsVu1FoDPZ4stz6brU0AsAzXnRb/jwqS/SHc V7UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=wocwYBxGPF/6AmhSJ9HPoNS/t/od0ib8DitlEPgrOak=; b=pN60FooCrxtQhikuYO0KdrTQ//qJYEy70o94dBQsGajkmP9psVDwIi91UqrO2BbYZ/ V04sv4nWZa9c8lD+s2rN8284zb9tf+vEEC1Ql85UUoDVdgui+m376aGvuTqLyUgsQ1oz DWv27adOzD2JiTC6yEoGfweeLT7NeWH5t3RTrR0KTyaXedfoidAAmBSkzx0b+zUTbvE2 JzCyEvb4TYmH6Po/Dx1p8tKX70lfb0LzHnFKv2p72AYQtDFPb4PUrcifR6aPwTU/esw9 r4hBc8bhE3lvMMZIO5Cnvx1e6pYxa0YKAKilTDmrkegSD2oBsFhFfd1s+VHaRxN7xEV8 WZdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5-v6si3399991pgu.432.2018.06.13.18.24.41; Wed, 13 Jun 2018 18:24:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935900AbeFNBYO (ORCPT + 99 others); Wed, 13 Jun 2018 21:24:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:34024 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754526AbeFNBYN (ORCPT ); Wed, 13 Jun 2018 21:24:13 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8057C40201D0; Thu, 14 Jun 2018 01:24:12 +0000 (UTC) Received: from ming.t460p (ovpn-12-71.pek2.redhat.com [10.72.12.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF38C210C6DC; Thu, 14 Jun 2018 01:23:58 +0000 (UTC) Date: Thu, 14 Jun 2018 09:23:54 +0800 From: Ming Lei To: Christoph Hellwig Cc: Jens Axboe , Alexander Viro , Kent Overstreet , David Sterba , Huang Ying , linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Theodore Ts'o , "Darrick J . Wong" , Coly Li , Filipe Manana , Randy Dunlap Subject: Re: [PATCH V6 11/30] block: implement bio_pages_all() via bio_for_each_segment_all() Message-ID: <20180614012352.GC19828@ming.t460p> References: <20180609123014.8861-1-ming.lei@redhat.com> <20180609123014.8861-12-ming.lei@redhat.com> <20180613144412.GB4693@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180613144412.GB4693@infradead.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 14 Jun 2018 01:24:12 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Thu, 14 Jun 2018 01:24:12 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ming.lei@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 13, 2018 at 07:44:12AM -0700, Christoph Hellwig wrote: > Given that we have a single, dubious user of bio_pages_all I'd rather > see it as an opencoded bio_for_each_ loop in the caller. Yeah, that is fine since there is only one user in btrfs. Thanks, Ming