Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1571909imm; Wed, 13 Jun 2018 23:44:27 -0700 (PDT) X-Google-Smtp-Source: ADUXVKILRSTwoKAZchEJ2pbIHMH8hW8aKm9DlP21BCs8gwXhhboVBZYJi8Rr+fQs1lnnYFmZvxLM X-Received: by 2002:a63:6807:: with SMTP id d7-v6mr1154636pgc.7.1528958667204; Wed, 13 Jun 2018 23:44:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528958667; cv=none; d=google.com; s=arc-20160816; b=sThqFxDvFVdk2Alhtmy6qPLR3+RG5z5rx7DqbkuUnrBkw7VZjT/jXznvY7Z/4QjJij wj4k3av5TC9YiF3KpDq5bY7ynaQBlfMnHW+vmawhfmDZbrIDCbixnUWCUdSlQd226Sy3 UHhzLywpwoxhKpMuUAsYG8X2SNTV1TN1vPUvbHOkMjkHJSLlzUx9MVjHoaR/nOxvM9Mj WC3qZhcuXmEHugp2qaS8OSI2oosNjTLPbF3e2vb/3shtP6BFsZdnVDdcmPgG85Bw9k6j RCOppmtK98KlyHZSDfd4Bfu+kjY/Lr1gIVbgmY/5svtJqMMShM9Kq9ZkZM7k19z4voZp JVzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=TKfEjlwhq8w8/ZBaylKknpCEvOiXd59bA31yewIVWUo=; b=x/cMY6iwRyhFpZ3QJj0xX/oG0Sz+jAEdWE8EnIOAFEnrh+M79m8oG/h5FbzPDVApXV Ub6zYO76hTZvPnD6+qKimdnnV8BFTPEGi3D9RMmJ1WUBZz2O2ZmamVVmZ/+4eaq9XKwL NEKFc2kvN48gQs87Q0jZyuBMeHFqrKq4TPzjzTVHkmtgc20zj0aZZeJwtuujhb8n3hFH OkRFwA3JaUYFYG6gd4ZZuOh/BpZZ9kJDK53X+p2PFfjQ/XigVVAZv8xOOablJCEeEXW+ Zaylj5B3JCSBoLfUAKBTP3fbBua1m0iJiqrQh5C1XD/Ml/ZOGDgnpCBeMoeSD2aFlG4c SgDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGa4vBoA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b12-v6si3856792pge.684.2018.06.13.23.44.12; Wed, 13 Jun 2018 23:44:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGa4vBoA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752921AbeFNGmz (ORCPT + 99 others); Thu, 14 Jun 2018 02:42:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:50094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752765AbeFNGmy (ORCPT ); Thu, 14 Jun 2018 02:42:54 -0400 Received: from localhost (LFbn-1-12247-202.w90-92.abo.wanadoo.fr [90.92.61.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 371D0208CB; Thu, 14 Jun 2018 06:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528958573; bh=952a7zewhQwc3UX+Vh5vvahSfthqdp4bW7St1GDj0uA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vGa4vBoA9I1YVQ0GFk5jX3Tj/Jqdbtyba/pcrHsMKaf9LCiGJNJvTZhcjfQHbkGgH 2hxf2/Hcj2AQvfC9iP22pkpsFJZ0L2xL43DOZBJRENcuIVWkgWa0KQW1xHu6DhhQeJ WlgeQSlNbApZb4GT80+FxGWRiApt+7K4qvzO7qmY= Date: Thu, 14 Jun 2018 08:42:29 +0200 From: Greg KH To: Parth Y Shah Cc: balbi@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] Fixed a checkpatch error Message-ID: <20180614064229.GA12429@kroah.com> References: <1528957966-24707-1-git-send-email-sparth1292@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528957966-24707-1-git-send-email-sparth1292@gmail.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 14, 2018 at 12:02:46PM +0530, Parth Y Shah wrote: > ERROR: code indent should use tabs where possible > > Here, spaces are replaced by a tab in 2 lines. > > Signed-off-by: Parth Y Shah Your subject line needs work, please see how other subject lines are composed for this subsystem. Also note, please do not use anything but the drivers/staging/ area of the kernel for beginning "I'm going to do checkpatch cleanups" type of "learning to get changes into the kernel" work. That is a great place to start with this, not in other subsystems where you might have reviewers who do not care so much about whitespace cleanups like this. So please learn the process there, and when you have it all working well, then you could move on to other subsystems and areas of the kernel, like this one, if you want to. thanks, greg k-h