Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1654071imm; Thu, 14 Jun 2018 01:25:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIOcCzt5A8VNV8Sx1g/WNQhdJidgr/Q3tRQCY+2Y0z2JrO1LUVf1CW79gIdw3ZR7jc9TRgA X-Received: by 2002:a62:2091:: with SMTP id m17-v6mr8361057pfj.110.1528964721558; Thu, 14 Jun 2018 01:25:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528964721; cv=none; d=google.com; s=arc-20160816; b=v4q9Ho7+HuDf8euGFh3LCPT7Qe5v9U0IiiTFbeEI9ECE9TSFtg2WfNgAoK5URTy0vn l37OfD78khPMI1EhkqblFy/SyMyfiZnufioOkMspSK9mGvo87dgaIUKC4O1+nZ+1+ASU +KhVVp6tRmyKrW4NRFk9ClJkFBcKPJvYzdVEIvNyTpnfCHWC5g/NDL/szTniigCe/H2g Fsp7Chz8b4GYZA9J8pG7WskJ89cX7ivL++wplrvI6k4soqCOar2Er5TQtRu6i2qqCMMw xcyHx1rxsIzwUsuCaDXjbSwEF5i0fj9KPcY946v5u6XAcMrCSpcyyQ2gC/3+ac3hdZq/ fPWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=yRDMgy64SpA8QrLa7EskGGSmTrENiJ98bTHJIs1B07Q=; b=tq0nWwSGJtoekzG43F5rBkO0oddch4qsgTEhVpJ8qMsZQqfsRSpiCgpyqde6ABjOFy nTejw9kG9NDhMD2Mj7KENuhb6VwH8AoxerWCLcneD97ku+n8Uodb0p4ay/NsEhf/5i1E pftsFfFAPH7BCnoaUEODRz5imTKRHxFDmtiPAbPEMlbo6D/m5XhXN5WNmC10BFOkflDG AFjIumk7xPty/xPNBhhD/GKPVx0krYumdsxwmm41hnM6zhHl81Vqy/JUWy9DO8uwef6o hv8zW1xelb/RFCx/tF+tdOJ8QwWj52AvfJjLh5T139ueJPgfDs/Yemp386z5ODDPcWKU CO5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j33-v6si4828589pld.151.2018.06.14.01.25.07; Thu, 14 Jun 2018 01:25:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbeFNIYf (ORCPT + 99 others); Thu, 14 Jun 2018 04:24:35 -0400 Received: from verein.lst.de ([213.95.11.211]:45107 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbeFNIYe (ORCPT ); Thu, 14 Jun 2018 04:24:34 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id C750568C4E; Thu, 14 Jun 2018 10:32:52 +0200 (CEST) Date: Thu, 14 Jun 2018 10:32:52 +0200 From: "hch@lst.de" To: "jianchao.wang" Cc: "hch@lst.de" , Bart Van Assche , "randrianasulu@gmail.com" , "rdunlap@infradead.org" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-block@vger.kernel.org" Subject: Re: kernel BUG at drivers/scsi/scsi_error.c:197! - git 4.17.0-x64-08428-g7d3bf613e99a Message-ID: <20180614083252.GA18536@lst.de> References: <201806091606.51078.randrianasulu@gmail.com> <025bf705-15b0-65e5-4b16-6c91d41c1730@infradead.org> <40617b19667b3c1302f8a903c19f2fa2f409b12a.camel@wdc.com> <5ca74fb7-af70-31c3-0e3f-bace058e5a57@oracle.com> <20180613140411.GA32701@lst.de> <09e8bd7605febd091679172d68ca1e9ca3990c91.camel@wdc.com> <20180613143558.GA1163@lst.de> <77932f7b-08ba-7ece-3778-d7da82772057@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77932f7b-08ba-7ece-3778-d7da82772057@oracle.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 14, 2018 at 03:49:28PM +0800, jianchao.wang wrote: > Yes, it will work for this issue. > But we should also clear the RQF_TIMED_OUT in __blk_mq_requeue_request and blk_mq_rq_ctx_init. blk_mq_rq_ctx_init always clears rq_flags, so we don't need to explcitly clear it. __blk_mq_requeue_request probablys needs it so that we handle the case of requeuing from the error handling indeed.