Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261455AbTIGVlw (ORCPT ); Sun, 7 Sep 2003 17:41:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261499AbTIGVlw (ORCPT ); Sun, 7 Sep 2003 17:41:52 -0400 Received: from pix-525-pool.redhat.com ([66.187.233.200]:10899 "EHLO lacrosse.corp.redhat.com") by vger.kernel.org with ESMTP id S261455AbTIGVlu (ORCPT ); Sun, 7 Sep 2003 17:41:50 -0400 Date: Sun, 7 Sep 2003 22:39:24 +0100 From: Dave Jones To: Andi Kleen Cc: Adrian Bunk , marcelo.tosatti@cyclades.com.br, linux-kernel@vger.kernel.org, Peter Daum Subject: Re: [2.4 patch] fix CONFIG_X86_L1_CACHE_SHIFT Message-ID: <20030907213924.GA28927@redhat.com> Mail-Followup-To: Dave Jones , Andi Kleen , Adrian Bunk , marcelo.tosatti@cyclades.com.br, linux-kernel@vger.kernel.org, Peter Daum References: <20030907195557.GK14436@fs.tum.de.suse.lists.linux.kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 36 On Sun, Sep 07, 2003 at 10:30:52PM +0200, Andi Kleen wrote: > Adrian Bunk writes: > > > With CONFIG_M686 CONFIG_X86_L1_CACHE_SHIFT was set to 5, but a Pentium 4 > > requires 7. > It doesn't require 7, it just prefers 7. *nod*. This 'fix' also papers over the bug instead of fixing it. Likely it's something like a network card driver setting its cacheline size incorrectly. Peter what NIC did you see the problem on ? I thought Ivan's PCI cacheline sizing fixes from 2.6 (see arch/i386/pci/common.c) already made it into 2.4, but from a quick grep, it seems that didn't happen. > > The patch below does: > > - set CONFIG_X86_L1_CACHE_SHIFT 7 for all Intel processors (needed for > > the Pentium 4) > > - set CONFIG_X86_L1_CACHE_SHIFT 6 for the K6 (needed for the Athlon) > I think these changes should be only done with CONFIG_X86_GENERIC is set. > Otherwise the people who want kernels really optimized for their CPUs > won't get the full benefit. On UP it does not make that much difference, > but on a SMP kernel having a bigger than needed cache size wastes a lot > of memory. ACK. Dave -- Dave Jones http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/