Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1970502imm; Thu, 14 Jun 2018 06:50:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLdftuK06+6DvZMNo2MSV+74yDx1F+qhXryDtyJUa3jaa+84jScNj2Ls2Yioe7wyxtIB9TT X-Received: by 2002:a17:902:7688:: with SMTP id m8-v6mr3151303pll.54.1528984233233; Thu, 14 Jun 2018 06:50:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528984233; cv=none; d=google.com; s=arc-20160816; b=NUHiuQxXiItoMGig/8OEUvOBA6RvdSacdF9GtV74VzfMHntxVWR+00YVN8wzYzPNnt ECqCBSfbyWYfZPA5nk/+EboRnPQBGpkwXPl9p89gPKuOYdZbjVZpi00zaXmbT62NzKDE REEc2J1n8Q+MKhR3k+vwZAkiXUfJDSeS6A2+eFEZ14m2XdEW72NyLsNLLOpU5lGSrOfu UpIg38nGC2AKnXfDoHj6dMvPx1G5MSayE3CDwER8Ph/rckg7wjaeDWVrFhNdhBHjaLd2 CSILtmbVrxH6tCY+Y4vifaE+Z9WkJcUcArP0da8JUuUVQfwwR4tGdBm9V68nzB/pvt1V kOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=UAY15v6mgKiHpP69S0KCEqlFd2iOICrqGBLVbRzMcX0=; b=xabKexy+/FWzkaVy7NanH6cAZIhp1p9XWm1sf11JnQt5BY00j/0EP4BdrqJhgC+0TO 8+7SCs9K18i/ZDg26BdHdHPEHkyNqql0S8gPgSZGHi5l/SVED1nm+kyiZbtYPlU6Oz1U k/zQ12p1X2xyRafHPxMnEaSUTA+5LpUPzySTXv9Dp6PQ/y/yBpwVCQmLdxKNN4fvzdC1 wlxbRyZWdihWSr+YZIJH7NTGbobjnQWvfY7q2aXQSn8YDVix0DU6Y97uaUEvVISa09aJ kVZgPBo+enfbMxnpqsv58knox1ktSB+l+33zoPscDha8O37KMM3hRCjl3q950VAs5PLc SKpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=M9gzMJer; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d13-v6si5589759pfe.214.2018.06.14.06.50.19; Thu, 14 Jun 2018 06:50:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=M9gzMJer; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755299AbeFNNsR (ORCPT + 99 others); Thu, 14 Jun 2018 09:48:17 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:46860 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754885AbeFNNsP (ORCPT ); Thu, 14 Jun 2018 09:48:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UAY15v6mgKiHpP69S0KCEqlFd2iOICrqGBLVbRzMcX0=; b=M9gzMJerKXiSOozbS7Jwsg5NN cJwlQiNHLmHGw2g8Vqn1MbFwUgcLh1FF7nrvKXgv8qM7gcNhYbs37yVap6/IJkgqbuoUlWRUdfgVB 6Uh/NIphjT563KU/bKRSqS9TWotAF5amBYhC2dNV3mW8u1EWDRxPPbzXfDtm+cOy4qumA=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fTSbZ-0003Wo-Tf; Thu, 14 Jun 2018 13:48:01 +0000 Received: from broonie by debutante with local (Exim 4.91) (envelope-from ) id 1fTSbZ-0007tl-Cp; Thu, 14 Jun 2018 14:48:01 +0100 Date: Thu, 14 Jun 2018 14:48:01 +0100 From: Mark Brown To: Robert Jarzmik Cc: Rob Herring , Liam Girdwood , Mark Rutland , Daniel Mack , Haojian Zhuang , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] ASoC: pxa: add binding for pxa2xx-ac97 audio complex Message-ID: <20180614134801.GB9660@sirena.org.uk> References: <20180611202211.15501-1-robert.jarzmik@free.fr> <20180612221359.GA26741@rob-hp-laptop> <87y3fiqzp8.fsf@belgarion.home> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZfOjI3PrQbgiZnxM" Content-Disposition: inline In-Reply-To: <87y3fiqzp8.fsf@belgarion.home> X-Cookie: 15% gratuity added for parties over 8. User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZfOjI3PrQbgiZnxM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 13, 2018 at 09:00:19PM +0200, Robert Jarzmik wrote: > Rob Herring writes: > > On Mon, Jun 11, 2018 at 10:22:10PM +0200, Robert Jarzmik wrote: > >> +Required properties: > >> + - compatible: "marvell,pxa2xx-ac97" > > Don't use wildcards in compatible strings. Though this is so old... > Yes, I could use pxa270-ac97. If you're going to do that then probably best to put in a compatible string for each SoC since they are actually meaningfully different, they seemed to manage to break something with each new revision. --ZfOjI3PrQbgiZnxM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEyBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlsichAACgkQJNaLcl1U h9CZ2wf2P8RJc94KqSk0E9cc7WOEzkM/bBC3w1dEkqBlm9nNNSmsUj81RlRFHpR2 BQztdPntC3jxepVMpyTIOGOJEhoYiIcT9yAbgoujIkaSSERjxKFyoDb00tTStjtg 6SQhPUnFDga+eXUiUhmfv8oFr4dP4PlEup43xoVnHhwLY6oo31MOVhQPrzHPb1uA OgbYVEG8RqatEsuk649UQ8KBEHKkWE3QCmb6vL0yGcZ8GVuaUrRh19gDEpX1ea3P ydTB/0L4gd7kMsk7LH1iwzcaD/mv1ztkw8m3NcQq9+i6hd0CGOp1G+T7YINvtism GESrxQk8QMvL13owbaCShtGsg15A =gAJc -----END PGP SIGNATURE----- --ZfOjI3PrQbgiZnxM--